dev-qemu: add sp-serial feature for the SP link#5
Open
dymk wants to merge 1 commit into
Open
Conversation
Add an off-by-default `sp-serial` feature to dev-qemu that selects uart-service's MctpSerialMedium (DSP0253) instead of the default SmbusEspiMedium, for the two-QEMU SP <-> EC serial link. The default build keeps SmbusEspi so the ec-test-cli integration-test stays green; the harness builds --features sp-serial. This is F1.1 re-pinned onto the modernized EC: default_mctp_serial now resolves directly from upstream embedded-services main (6d7dbbf, the merged #906 ctor) with no fork [patch] override. Assisted-by: GitHub Copilot:claude-opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an off-by-default
sp-serialfeature todev-qemuthat selects uart-service'sMctpSerialMedium(DSP0253 framing) instead of the defaultSmbusEspiMedium, for the two-QEMU SP ↔ EC serial link. Pure compile-time selector — both medium constructors already live inuart-service; dev-qemu holds no wire addressing.Why
The default build keeps
SmbusEspi(the framingec-test-clispeaks), so the single-QEMUintegration-teststays green. Thesp-serialfeature selects the serial medium the Secure Partition speaks over the two-QEMU link; the qemu-sbsa harness builds--features sp-serial.Context
Builds on OpenDevicePartnership#33 (EC modernized to
embedded-servicesmain):default_mctp_serialnow resolves directly from upstreamembedded-servicesmain — no fork[patch].Verification
--features sp-serial(DSP0253).fmt --check+clippyclean.odp-platform-qemu-sbsatest-sp-ec-link): the full UEFI ↔ FFA ↔ SP ↔ DSP0253-serial ↔ EC thermalGetTmpround-trip passes (ffa_version/ffa_id_get/partition_discovery/thermal_get_temperatureall green). Thesp-serialcode path is unchanged by the rebase onto merged main.Assisted-by: GitHub Copilot:claude-opus-4.8