dev-qemu: select MCTP medium via sp-serial feature#3
Open
dymk wants to merge 1 commit into
Open
Conversation
Add an off-by-default sp-serial cargo feature to dev-qemu. The default build keeps SmbusEspiMedium (default_smbusespi), so ec-test-cli and the in-repo integration-test job keep working; sp-serial selects MctpSerialMedium via uart_service::default_mctp_serial for the two-QEMU SP<->EC serial link. Both arms are one-liners over uart-service's per-medium constructors, so dev-qemu holds no wire addressing and needs no direct mctp-rs dependency. Enabling serial pulls in crc + crc-catalog (DSP0253 FCS-16); add the cargo-vet exemptions. TEMPORARY: a [patch] block pins the embedded-services crates to a dymk fork commit = the EC's current pin (62d4ea9) + only the default_mctp_serial constructor, so this builds with zero platform-common churn. Remove the [patch] once default_mctp_serial merges upstream and the EC is modernized to embedded-services main (separate epic). Assisted-by: GitHub Copilot:claude-opus-4.8
Owner
Author
|
E2E verified green. The serial change was proven end-to-end on the two-QEMU SP↔EC harness. Because EC OpenDevicePartnership#28 (current main) migrated dev-qemu off the QEMU The EC-origin DeciKelvin round-tripped through the real SP↔EC MCTP-over-serial link — confirming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an off-by-default
sp-serialcargo feature todev-qemu.SmbusEspiMedium(default_smbusespi), soec-test-cliand the in-repointegration-testjob keep working.sp-serialselectsMctpSerialMediumviauart_service::default_mctp_serialfor the two-QEMU SP↔EC serial link. Both arms are one-liners over uart-service's per-medium constructors —dev-qemuholds no wire addressing and needs no directmctp-rsdep.crc+crc-catalog(DSP0253 FCS-16); cargo-vet exemptions added.Depends on the
uart_service::default_mctp_serialconstructor (dymk/embedded-services#12).TEMPORARY
[patch]: pins embedded-services crates to a dymk fork commit = the EC's current pin (62d4ea9) + only thedefault_mctp_serialconstructor, so this builds with zero platform-common churn. Remove once the constructor merges upstream and the EC is modernized to embedded-services main (tracked as a separate epic — the EC is currently 8 commits behind, and bumping requires a battery-service Registration-model migration).Verification: all build/lint/supply-chain gates green in both feature configs (fmt, clippy ×2, build ×2,
check --all-features, feature-powerset ×4, machete, deny). The two-QEMU SP↔EC e2e (test-sp-ec-link) is pending devcontainer verification. (cargo +1.83MSRV and the local cargo-vet store-format error are pre-existing onmain, unrelated to this change.)Fork PR for review before promoting upstream.
Assisted-by: GitHub Copilot:claude-opus-4.8