feat: make comments keyboard-focusable#3
Merged
Conversation
Member
Author
Final implementation reportSaved comments are now fully editable with the keyboard:
Verification
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keyboard navigation skipped inline comments, so editing an existing comment was not a complete keyboard flow.
Up/Down and
j/know stop on comment rows, and Enter opens the focused comment for editing.The focused comment gets its own marker and stays visible while the document scrolls.
What Changed
Comments now participate in the same semantic navigation order users see on screen.
Source range selection remains source-oriented, while normal browsing can move through source lines and comments.
▶─focus marker to inline comments and hid the source marker while comment focus is active.Testing
The new flow is covered from app state through a real tmux pseudoterminal session.
The tmux scenario creates a comment, restarts without mouse support, navigates to the inline comment, opens it, changes it, saves it, and verifies the resulting Markdown.
cargo fmt --all -- --checkcargo test --workspace --all-targets— 58 unit tests and 3 architecture tests passed.cargo clippy --workspace --all-targets --all-features -- -D warningsscripts/e2e-tmux.shscripts/ci-local.sh— 97.55% line coverage; 132 mutants tested, with 127 caught and 5 unviable; dependency audit, Slophammer, and SimpleDoc checks passed.cargo +1.88.0 check --workspaceRisks
Risk is low because the change is limited to browse focus and rendering state.
Mouse editing, Shift range selection, page movement, and output formats retain their existing paths and remain covered by the full gate.