Use tmp dir for SERVER_DIR_PATH in tests - #4121
Merged
Merged
Conversation
Paths under SERVER_DIR_PATH were bound at import time, so tests could not redirect them and every pytest-xdist worker shared the real ~/.dstack/server. Workers raced mkdir against rmtree on the same instance connection dir, which flaked tests under -n auto. Importing the server no longer creates the data dir or a DB engine either. Fixes #4095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4095
The tests used dstack's default
~/.dstack/serverdir for SERVER_DIR_PATH and relied on per-tests ad-hoc monkey patching in case tests write to SERVER_DIR_PATH. In some places the patching was missing which could lead to non-deterministic test failures.Now every test session uses a tmp dir for SERVER_DIR_PATH. Subpaths of SERVER_DIR_PATH are derived at runtime to support overriding via pytest fixtures.