Conversation
…t to restore previous behavior
…fault problem a different way
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 54 54
Lines 7085 7089 +4
Branches 1138 1138
=======================================
+ Hits 6865 6869 +4
- Misses 152 153 +1
+ Partials 68 67 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
action='append'to exclude default(s), and addsaction='append_default'for use cases that require the previous behavior.This is technically a minor breaking change. The previous behavior was frequently considered to be surprising behavior, it often caused subtle bugs, and it resulted in many less than ideal workarounds.
For any use cases where
nargs='+'or similar and the inclusion of default value(s) is desired when explicit arguments are provided,action='append_default'needs to be explicitly specified for the relevant parameter(s).