Skip to content

Migrate rm and share-link revoke dry-run to renderOperation #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyVMarkelov merged 1 commit into from
Jul 10, 2026
Merged

Migrate rm and share-link revoke dry-run to renderOperation #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/rm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ func rm(cmd *cobra.Command, args []string) error {
return err
}

return commandOutput(cmd).Render(func(w io.Writer) error {
return renderOperation(cmd, nil, removeOperationResults(results), nil, func(w io.Writer) error {
if !opts.dryRun && !opts.verbose {
return nil
}
return renderRemoveResults(w, results)
}, newJSONCommandOperationOutput(cmd, nil, removeOperationResults(results), nil))
})
}

func removeOperationResults(results []removeResult) []jsonOperationResult {
Expand Down
4 changes: 2 additions & 2 deletions cmd/share_link_revoke.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func revokeSharedLinksForPath(cmd *cobra.Command, path string, dryRun bool) ([]s
}

func renderShareLinkRevokeOutput(cmd *cobra.Command, input shareLinkRevokeInput, results []jsonOperationResult) error {
return commandOutput(cmd).Render(func(w io.Writer) error {
return renderOperation(cmd, input, results, nil, func(w io.Writer) error {
if !input.DryRun {
return nil
}
Expand All @@ -191,7 +191,7 @@ func renderShareLinkRevokeOutput(cmd *cobra.Command, input shareLinkRevokeInput,
}
}
return nil
}, newJSONCommandOperationOutput(cmd, input, results, nil))
})
}

var shareLinkRevokeCmd = &cobra.Command{
Expand Down
Loading