feat(design-system): add DsSlider component [AR-77548] - #629
Open
vpolessky-dn wants to merge 5 commits into
Open
feat(design-system): add DsSlider component [AR-77548]#629vpolessky-dn wants to merge 5 commits into
vpolessky-dn wants to merge 5 commits into
Conversation
✅ Deploy Preview for drivenets-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
iromanchuk-dn
changed the title
| * Drives thumb and track sizing together (S/M/L → 16/20/24px thumb, 2/4/8px track). | ||
| * @default 'medium' | ||
| */ | ||
| size?: DsSliderSize; |
Collaborator
There was a problem hiding this comment.
Let's make this prop responsive
| * Granularity that the value snaps to. Must be greater than 0. | ||
| * @default 1 | ||
| */ | ||
| step?: number; |
Collaborator
There was a problem hiding this comment.
Let's make this prop responsive
| /** | ||
| * Accessible name per thumb. Required for `type="range"` (e.g. `['Minimum', 'Maximum']`). | ||
| */ | ||
| thumbLabels?: string[]; |
Collaborator
There was a problem hiding this comment.
Let's make this prop responsive
Comment on lines
+8
to
+14
| const toArray = (value: DsSliderValue | undefined): number[] | undefined => { | ||
| if (value === undefined) { | ||
| return undefined; | ||
| } | ||
|
|
||
| return Array.isArray(value) ? value : [value]; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Let's extract it into ds-slider.utils.ts
| flex: 1; | ||
| height: var(--ds-slider-track-height); | ||
| background: var(--background-secondary-hover); | ||
| border-radius: 9999px; |
Collaborator
There was a problem hiding this comment.
Let's make scss var for this value
| outline: none; | ||
| cursor: pointer; | ||
| transition: | ||
| width 0.2s, |
Collaborator
There was a problem hiding this comment.
Let's make scss var for 0.2s
Collaborator
There was a problem hiding this comment.
Include this component into "packages/design-system/tests/storybook/docs-snippets.docs.test.ts" and make sure code snippets look good.
iromanchuk-dn
requested changes
Jul 29, 2026
iromanchuk-dn
left a comment
iromanchuk-dn
left a comment
Collaborator
There was a problem hiding this comment.
Looks great!
I've left several comments
…to feat/AR-77548-add-slider_v01
iromanchuk-dn
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.