Skip to content

Adding PDB and Intellisense file for Microsoft.Private.Windows.Core assembly to the NuGet package#14596

Open
Shyam-Gupta wants to merge 3 commits into
mainfrom
dev/shgu/symbols
Open

Adding PDB and Intellisense file for Microsoft.Private.Windows.Core assembly to the NuGet package#14596
Shyam-Gupta wants to merge 3 commits into
mainfrom
dev/shgu/symbols

Conversation

@Shyam-Gupta
Copy link
Copy Markdown
Member

@Shyam-Gupta Shyam-Gupta commented Jun 1, 2026

Issue: In addition to the main NuGet package, the VMR official build produces a separate Microsoft.Private.Windows.Core.<BuildNumber>.symbols.nupkg which should contain the PDB files for symbol upload. The current package was not adding these files.

Fix: The change adds the missing files to the package. It was also bringing in the output assembly of the package project itself. Since this is not needed, we remove it from the final package.

Testing: Built both the packages locally and ensured that the correct PDB and Intellisense files are present in the packages.

Microsoft Reviewers: Open in CodeFlow

@Shyam-Gupta Shyam-Gupta requested a review from a team as a code owner June 1, 2026 22:23
@Shyam-Gupta Shyam-Gupta self-assigned this Jun 1, 2026
JeremyKuhne
JeremyKuhne previously approved these changes Jun 1, 2026
merriemcgaw
merriemcgaw previously approved these changes Jun 1, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Microsoft.Private.Windows.Core packaging project to ensure that generated symbol and documentation artifacts (PDB and XML) are included in the appropriate NuGet outputs, and to avoid unintentionally packing the packaging project’s own build outputs.

Changes:

  • Enables symbol packing for the package project and adds a target to include Microsoft.Private.Windows.Core.pdb in the symbols package.
  • Adds the Microsoft.Private.Windows.Core.xml documentation file to the package content.
  • Strips the packaging project’s own build outputs and debug symbols so only the intended assembly artifacts are packed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants