Adding PDB and Intellisense file for Microsoft.Private.Windows.Core assembly to the NuGet package#14596
Open
Shyam-Gupta wants to merge 3 commits into
Open
Adding PDB and Intellisense file for Microsoft.Private.Windows.Core assembly to the NuGet package#14596Shyam-Gupta wants to merge 3 commits into
Shyam-Gupta wants to merge 3 commits into
Conversation
…assembly to the NuGet package.
JeremyKuhne
previously approved these changes
Jun 1, 2026
merriemcgaw
previously approved these changes
Jun 1, 2026
…ll happen only for Release CI builds.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.Private.Windows.Core packaging project to ensure that generated symbol and documentation artifacts (PDB and XML) are included in the appropriate NuGet outputs, and to avoid unintentionally packing the packaging project’s own build outputs.
Changes:
- Enables symbol packing for the package project and adds a target to include
Microsoft.Private.Windows.Core.pdbin the symbols package. - Adds the
Microsoft.Private.Windows.Core.xmldocumentation file to the package content. - Strips the packaging project’s own build outputs and debug symbols so only the intended assembly artifacts are packed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
merriemcgaw
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: In addition to the main NuGet package, the VMR official build produces a separate
Microsoft.Private.Windows.Core.<BuildNumber>.symbols.nupkgwhich should contain the PDB files for symbol upload. The current package was not adding these files.Fix: The change adds the missing files to the package. It was also bringing in the output assembly of the package project itself. Since this is not needed, we remove it from the final package.
Testing: Built both the packages locally and ensured that the correct PDB and Intellisense files are present in the packages.
Microsoft Reviewers: Open in CodeFlow