Skip to content

Fix svcutil endpoint configurations generation #4843

Open
petarpetrovt wants to merge 1 commit into
dotnet:mainfrom
petarpetrovt:main
Open

Fix svcutil endpoint configurations generation #4843
petarpetrovt wants to merge 1 commit into
dotnet:mainfrom
petarpetrovt:main

Conversation

@petarpetrovt

@petarpetrovt petarpetrovt commented Jun 15, 2022

Copy link
Copy Markdown

Fixes #4828

  • CertificateOverTransport
  • IssuedTokenOverTransport - Not sure how IssuedSecurityTokenParameters parameter should be generated.
  • KerberosOverTransport
  • SspiNegotiatedOverTransport - Not sure how requireCancellation parameter should be generated.
  • UserNameOverTransport

@HongGit

HongGit commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

@petarpetrovt can you please rebase and submit changes to fix the build pipeline issue?

What is your plan for the two unchecked items?

@mos379

mos379 commented Nov 8, 2023

Copy link
Copy Markdown

Anyone till looking into this?

@petarpetrovt

Copy link
Copy Markdown
Author

@mos379 nah, feel free to take it :)

@mconnew

mconnew commented May 21, 2025

Copy link
Copy Markdown
Member

@imcarolwang, can you look at the changes here and see if we're still missing what this change adds? If we are still missing this, can you validate that these changes do the right thing?

@imcarolwang

Copy link
Copy Markdown
Contributor

We're still missing the changes addressed in this PR, the tool's existing implementation hard code to generate UserNameOverTransportBindingElement when configuring TransportSecurityBindingElement for CustomBinding . This PR generally includes the necessary changes to resolve the issue.

Regarding the unchecked checkbox items mentioned by the author in the PR description, PR #5789 was created attempting to address this. The new PR incorporates all the existing changes from this PR, along with added test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

svcutil generating incorrect client for WSHttpBinding with SecurityMode.TransportWithMessageCredential

5 participants