Use eng\common\dotnet.cmd instead of .\dotnet.cmd in crossgen2 comparison legs#131007
Draft
jtschuster wants to merge 1 commit into
Draft
Use eng\common\dotnet.cmd instead of .\dotnet.cmd in crossgen2 comparison legs#131007jtschuster wants to merge 1 commit into
jtschuster wants to merge 1 commit into
Conversation
jtschuster
added
area-ReadyToRun
and removed
area-crossgen2-coreclr
Member
Author
|
/azp run runtime-coreclr crossgen2 outerloop |
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the crossgen2 comparison build job to avoid using the repo-root dotnet.cmd wrapper in Windows comparison runs, reducing contention around artifacts/toolset/sdk.txt when many parallel dotnet invocations occur.
Changes:
- Removed the “pre-initialize dotnet CLI” step that existed to mitigate parallel
dotnet.cmdraces. - Switched the Windows
--dotnetargument passed tocrossgen2_comparison.pyfrom$(Build.SourcesDirectory)\dotnet.cmdto$(Build.SourcesDirectory)\eng\common\dotnet.cmd.
Comment on lines
141
to
144
| crossgen_framework | ||
| --crossgen $(crossgen2location) | ||
| --dotnet $(Build.SourcesDirectory)\dotnet.cmd | ||
| --dotnet $(Build.SourcesDirectory)\eng\common\dotnet.cmd | ||
| --core_root $(workItemDirectory)\dlls |
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet.cmd unconditionally calls
InitializeDotnetCLI $true $truewhich locks sdk.txt for a short period during startup. Later in the batch file, sdk.txt is read. In crossgen2 comparison jobs, over 200 parallel invocations happen at once, so occasionally sdk.txt is locked when trying to read, and the eventual call to the dotnet cli fails.Instead, use
.\eng\common\dotnet.ps1to invoke the cli, which doesn't touch sdk.txt.Fixes #131004
Fixes #131005