Skip to content

Bring managed cDAC process APIs in line with newer contract expectations#130998

Draft
rcj1 with Copilot wants to merge 5 commits into
mainfrom
copilot/wip-remove-extraneous-files
Draft

Bring managed cDAC process APIs in line with newer contract expectations#130998
rcj1 with Copilot wants to merge 5 commits into
mainfrom
copilot/wip-remove-extraneous-files

Conversation

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Description

The managed cDAC reader was missing process-side implementations for several IXCLRDataProcess entry points that the newer contract surface expects. This change brings that path back in line so diagnostics scenarios can enumerate and resolve app domains, modules, and tasks through the managed reader without falling back to incomplete behavior.

  • Implemented app-domain enumeration and lookup by unique ID.
  • Implemented module enumeration and address-based module resolution using the current loader contracts.
  • Implemented task lookup by unique ID and address-type classification for managed/runtime code addresses.
  • Added and updated unit coverage for the affected IXCLRDataProcess behaviors.

Customer Impact

Without this, cDAC consumers using the managed reader can fail to enumerate or resolve core runtime objects such as app domains, modules, and tasks, which breaks diagnostics and inspection scenarios that depend on these APIs.

Regression

This fixes a regression in the managed cDAC implementation path after the IXCLRDataProcess surface was expanded to include these behaviors.

Testing

Covered by the managed cDAC unit test suite for IXCLRDataProcess, including app-domain, module, task, address-type, and related behavior tests.

Risk

Low. The change is localized to the managed cDAC IXCLRDataProcess implementation and is exercised by the existing cDAC unit tests.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Copilot AI and others added 5 commits July 17, 2026 21:00
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI self-assigned this Jul 17, 2026
Copilot AI review requested due to automatic review settings July 17, 2026 21:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI changed the title [WIP] cDAC process API parity and module enumeration updates Bring managed cDAC process APIs in line with newer contract expectations Jul 17, 2026
Copilot finished work on behalf of rcj1 July 17, 2026 21:24
Copilot AI requested a review from rcj1 July 17, 2026 21:24
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants