Skip to content

[WIP] Add method extent enumeration support to legacy cDAC#130996

Draft
rcj1 with Copilot wants to merge 4 commits into
mainfrom
copilot/6944fe7764ae6f34a8079864f0f79cc0e6eb59a8-0e94bde20
Draft

[WIP] Add method extent enumeration support to legacy cDAC#130996
rcj1 with Copilot wants to merge 4 commits into
mainfrom
copilot/6944fe7764ae6f34a8079864f0f79cc0e6eb59a8-0e94bde20

Conversation

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

This change adds the minimal legacy cDAC support needed to expose a method extent through IXCLRDataMethodInstance by implementing StartEnumExtents, EnumExtent, and EndEnumExtents. The implementation is intentionally scoped to the pieces required from the referenced commits and follows the existing enum-handle pattern used by the legacy reader.

  • Summary
    • Adds extent enumeration support for legacy method instances so callers can enumerate the method's native code range through the cDAC path.
  • What changed
    • Introduces the minimal internal state needed to represent a single method extent and drive the enum lifecycle.
    • Resolves the method extent from runtime metadata, execution-manager state, and GC info.
    • Wires the three new entry points into the legacy ClrDataMethodInstance implementation and preserves debug-time validation against the legacy implementation.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 17, 2026 19:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI temporarily deployed to copilot-pat-pool July 17, 2026 19:57 Inactive
Copilot AI changed the title [WIP] Add support for method extent enumeration in legacy cDAC [WIP] Add method extent enumeration support to legacy cDAC Jul 17, 2026
Copilot finished work on behalf of rcj1 July 17, 2026 19:57
Copilot AI requested a review from rcj1 July 17, 2026 19:57
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
11 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI temporarily deployed to copilot-pat-pool July 17, 2026 19:57 Inactive
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 18, 2026 05:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 18, 2026 05:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 18, 2026 05:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot finished work on behalf of rcj1 July 18, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants