Skip to content

[WIP] [cDAC] Implement remaining IXCLRDataStackWalk APIs#130995

Draft
rcj1 with Copilot wants to merge 3 commits into
mainfrom
copilot/combine-commits-sequentially
Draft

[WIP] [cDAC] Implement remaining IXCLRDataStackWalk APIs#130995
rcj1 with Copilot wants to merge 3 commits into
mainfrom
copilot/combine-commits-sequentially

Conversation

Copilot AI commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This draft PR consolidates the requested cDAC stack-walking changes into a single reviewable sequence. It brings together the stack-walk implementation work, the allocation guard for StackWalk requests, and the x86 context fix so the behavior can be reviewed as a coherent unit.

  • Summary

    • Combines three related cDAC stack-walk changes into one PR for review.

  • What changed

    • Implemented cDAC support for IXCLRDataStackWalk.
    • Prevented unbounded StackWalk request allocation in the request path.
    • Fixed x86 stack-context handling in the relevant contract reader logic.

Copilot AI and others added 3 commits July 17, 2026 19:13
@rcj1
Implement cDAC IXCLRDataStackWalk
6c24857 
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
(cherry picked from commit 4d9f1ca)
@rcj1
Avoid unbounded StackWalk request allocation
166fa9c 
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
(cherry picked from commit fc5a070)
@rcj1
Fix x86 stack context handling
0764d66 
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
(cherry picked from commit 5864d00)
Copilot AI review requested due to automatic review settings July 17, 2026 19:13
Copilot AI reviewed Jul 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title [WIP] Combine requested commits [WIP] Combine cDAC StackWalk fixes Jul 17, 2026
Copilot finished work on behalf of rcj1 July 17, 2026 19:14
Copilot AI requested a review from rcj1 July 17, 2026 19:14
@azure-pipelines

azure-pipelines Bot commented Jul 17, 2026

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 5 pipeline(s).
10 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI temporarily deployed to copilot-pat-pool July 17, 2026 19:19 Inactive
Copilot AI temporarily deployed to copilot-pat-pool July 17, 2026 19:19 Inactive
@rcj1 rcj1 changed the title [WIP] Combine cDAC StackWalk fixes [WIP] [cDAC] Implement remaining StackWalk DAC APIs Jul 17, 2026
@rcj1 rcj1 changed the title [WIP] [cDAC] Implement remaining StackWalk DAC APIs [WIP] [cDAC] Implement remaining IXCLRDataStackWalk APIs Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@rcj1 rcj1 Awaiting requested review from rcj1

At least 1 approving review is required to merge this pull request.

Assignees

@rcj1 rcj1

Copilot code review Copilot

Labels

area-Diagnostics-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcj1