Skip to content

Use MSVC_DEBUG_INFORMATION_FORMAT for CoreCLR object libraries #130983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elinor-fung wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −17
Open

Use MSVC_DEBUG_INFORMATION_FORMAT for CoreCLR object libraries #130983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions src/coreclr/clrdatadescriptors.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,20 +90,11 @@ function(generate_data_descriptors)
target_include_directories(${LIBRARY} PRIVATE ${GENERATED_CDAC_DESCRIPTOR_DIR})

if(MSVC)
# Give this OBJECT library a deterministic, per-target compile PDB. Without this,
# MSVC writes debug info to the default `vc140.pdb`, which does not travel with
# the .obj files when they are archived into a static library (e.g.
# Runtime.ServerGC.lib). Downstream linkers - notably the NativeAOT publish
# of ILCompiler/crossgen2/ilasm/mscordaccore_universal - then emit LNK4099
# ("PDB ... was not found"), which is fatal under /WX in the VMR build.
set_target_properties(${LIBRARY} PROPERTIES
COMPILE_PDB_NAME "${LIBRARY}"
COMPILE_PDB_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/$<CONFIG>")
# Even with a per-target PDB name, the external PDB stays in the producer's
# binary dir and is not visible to downstream linkers consuming the static lib.
# Embed CodeView debug info directly into each .obj (/Z7) so the debug data
# travels with the object when it is archived into the static library, removing
# the need for the linker to find a separate PDB and silencing LNK4099.
target_compile_options(${LIBRARY} PRIVATE /Z7)
# Embed debug info in the object files (/Z7). CMake does not assign a compile
# PDB to OBJECT libraries, so the objects archived into a static library (e.g.
# Runtime.ServerGC.lib) would otherwise reference an absent vc140.pdb, producing
# LNK4099 for the NativeAOT publish of ILCompiler/crossgen2/ilasm/mscordaccore_universal,
# which is fatal under /WX in the VMR build.
Comment thread
elinor-fung marked this conversation as resolved.
set_target_properties(${LIBRARY} PROPERTIES MSVC_DEBUG_INFORMATION_FORMAT Embedded)
endif()
endfunction(generate_data_descriptors)
4 changes: 2 additions & 2 deletions src/coreclr/nativeaot/Runtime/Full/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ if (CLR_CMAKE_TARGET_WIN32)
# objects archived into Runtime.WorkstationGC/Runtime.ServerGC would otherwise
# reference a vc140.pdb that is absent when these static libs are statically
# linked by the AOT compiler publish projects, producing LNK4099.
target_compile_options(Runtime.GC.Workstation PRIVATE /Z7)
target_compile_options(Runtime.GC.Server PRIVATE /Z7)
set_target_properties(Runtime.GC.Workstation PROPERTIES MSVC_DEBUG_INFORMATION_FORMAT Embedded)
set_target_properties(Runtime.GC.Server PROPERTIES MSVC_DEBUG_INFORMATION_FORMAT Embedded)
endif (CLR_CMAKE_TARGET_WIN32)

add_library(Runtime.WorkstationGC STATIC
Expand Down
Loading