Enable previously suppressed tests on CoreCLR browser by radekdoulik · Pull Request #130970 · dotnet/runtime

radekdoulik · 2026-07-17T13:26:11Z

Summary

Narrow several runtime-test ActiveIssue conditions so tests that work with CoreCLR on browser/wasm are no longer suppressed.

Keep browser suppressions where they are still needed for Mono.
Enable the affected SIMD, JIT, GC, hardware-intrinsics, and base-services tests on CoreCLR browser.
Keep StackallocBlkTests suppressed for Mono and NativeAOT while enabling it on CoreCLR desktop and browser.
Add shared CoreCLR runtime detection to PlatformDetection.
Synchronize the Runtime_64125 T4 template with its generated source.

Testing

./build.sh clr+libs -lc release -rc checked
./build.sh -arch wasm -os browser -c Debug -subset clr+libs
Browser/wasm priority-1 test build
Affected runners: 5,654 total, 5,643 passed, 0 failed, 11 skipped
Broad browser suite: 14,691 total, 14,296 passed, 2 failed, 393 skipped

The two broad-suite failures are unrelated upstream regressions:

TestConvertFromIntegral in JIT.IL_Conformance
b05617 in JIT.Regression.Regression_7

All executable tests affected by this change passed.

Note

This description was generated with GitHub Copilot.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Keep the T4 source aligned with the generated xUnit entry point and ActiveIssue attributes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Keep the test enabled on CoreCLR desktop and browser while retaining suppression for Mono and NativeAOT. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Move the reusable runtime classification to PlatformDetection and use it for the StackallocBlkTests ActiveIssue condition. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

azure-pipelines · 2026-07-17T13:26:56Z

Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-17T13:27:12Z

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR narrows a set of ActiveIssue suppression conditions so more runtime tests run on CoreCLR browser/wasm, while keeping suppressions for Mono / other configurations where they’re still needed.

Changes:

Adjust ActiveIssue predicates in several JIT/GC/base-services tests to skip browser only on Mono (or skip interpreter only outside CoreCLR browser).
Add PlatformDetection.IsCoreCLR / IsNotCoreCLR helpers in the shared CoreCLR test library.
Update Runtime_64125 T4 template and synchronize its generated .cs output.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/tests/JIT/SIMD/Matrix4x4.cs	Refines interpreter skip condition to not suppress on CoreCLR browser.
src/tests/JIT/Regression/JitBlue/Runtime_64125/Runtime_64125.tt	Updates generated-test template to use xUnit + targeted `ActiveIssue` conditions.
src/tests/JIT/Regression/JitBlue/Runtime_64125/Runtime_64125.cs	Regenerated output to match template changes / updated skip conditions.
src/tests/JIT/opt/Vectorization/StackallocBlkTests.cs	Switches suppression to use new `PlatformDetection.IsNotCoreCLR` helper.
src/tests/JIT/Methodical/eh/interactions/switchinfinally.cs	Narrows browser suppression to Mono browser only.
src/tests/JIT/HardwareIntrinsics/General/HwiOp/HwiSideEffects.cs	Narrows browser suppression to Mono browser only.
src/tests/GC/Coverage/271010.cs	Changes suppression from “CoreCLR” to a custom predicate excluding browser.
src/tests/Common/CoreCLRTestLibrary/PlatformDetection.cs	Adds shared CoreCLR vs non-CoreCLR runtime detection helpers.
src/tests/baseservices/invalid_operations/ManagedPointers.cs	Splits browser suppression to Mono browser only (and keeps Apple mobile suppressed).
src/tests/baseservices/invalid_operations/Arrays.cs	Splits browser suppression to Mono browser only (and keeps Apple mobile suppressed).

Use the shared CoreCLR runtime detection for GC 271010 and remove a redundant Apple mobile suppression from Runtime_64125. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1e841e19-0192-4e92-a86d-8b8a4ffca32d

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

lewing · 2026-07-17T17:01:53Z

    private class TestClass { }

-    [ActiveIssue("Function mismatch", TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
+    [ActiveIssue("Function mismatch", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]


I'm curious. do these also pass on apple in coreclr?

maraf · 2026-07-17T18:20:28Z

        public static bool IsExceptionInteropSupported => IsWindows && !Utilities.IsNativeAot && !Utilities.IsMonoRuntime && !Utilities.IsCoreClrInterpreter;

        public static bool IsMonoRuntime => Type.GetType("Mono.RuntimeStructs") != null;
+        public static bool IsCoreCLR => !IsMonoRuntime && Utilities.IsNotNativeAot;


Is this how we treat CoreCLR vs NativeAOT in other places as well (that NativeAOT is not CoreCLR)? Or should we be more explicit in the naming?

radekdoulik and others added 10 commits July 17, 2026 13:58

Enable Matrix4x4 on CoreCLR browser

21a18eb

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Enable switch-in-finally tests on CoreCLR browser

4c59e6b

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Enable Runtime_64125 on CoreCLR browser

2f95c61

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Enable invalid-operation tests on CoreCLR browser

ad64f57

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Narrow HwiSideEffects suppression to Mono browser

df0b4b7

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Enable GC 271010 on CoreCLR browser

ff6c564

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Correct StackallocBlkTests ActiveIssue condition

3190f67

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Synchronize Runtime_64125 test template

ad299bc

Keep the T4 source aligned with the generated xUnit entry point and ActiveIssue attributes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Limit StackallocBlkTests suppression by runtime

d6b6158

Keep the test enabled on CoreCLR desktop and browser while retaining suppression for Mono and NativeAOT. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Share CoreCLR runtime detection

f00a1c6

Move the reusable runtime classification to PlatformDetection and use it for the StackallocBlkTests ActiveIssue condition. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1dc3d8ec-ff97-4a7d-bfec-0f98ccd3db5f

Copilot AI review requested due to automatic review settings July 17, 2026 13:26

github-actions Bot added the area-Infrastructure-coreclr Only use for closed issues label Jul 17, 2026

github-project-automation Bot added this to Runtime Infra Jul 17, 2026

radekdoulik added this to the 11.0.0 milestone Jul 17, 2026

dotnet-policy-service Bot assigned radekdoulik Jul 17, 2026

radekdoulik added the arch-wasm WebAssembly architecture label Jul 17, 2026

Copilot started reviewing on behalf of radekdoulik July 17, 2026 13:26 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

Comment thread src/tests/GC/Coverage/271010.cs

Comment thread src/tests/JIT/Regression/JitBlue/Runtime_64125/Runtime_64125.tt Outdated

Address ActiveIssue review feedback

7019627

Use the shared CoreCLR runtime detection for GC 271010 and remove a redundant Apple mobile suppression from Runtime_64125. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1e841e19-0192-4e92-a86d-8b8a4ffca32d

Copilot AI review requested due to automatic review settings July 17, 2026 14:13

Copilot started reviewing on behalf of radekdoulik July 17, 2026 14:13 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

lewing reviewed Jul 17, 2026

View reviewed changes

maraf approved these changes Jul 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable previously suppressed tests on CoreCLR browser#130970

Enable previously suppressed tests on CoreCLR browser#130970
radekdoulik wants to merge 11 commits into
dotnet:mainfrom
radekdoulik:radekdoulik-activeissue-cleanup-main

radekdoulik commented Jul 17, 2026

Uh oh!

azure-pipelines Bot commented Jul 17, 2026

Uh oh!

dotnet-policy-service Bot commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

lewing Jul 17, 2026

Uh oh!

maraf Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

radekdoulik commented Jul 17, 2026

Summary

Testing

Uh oh!

azure-pipelines Bot commented Jul 17, 2026

Uh oh!

dotnet-policy-service Bot commented Jul 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

lewing Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

maraf Jul 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants