Skip to content

Raise InternalBufferOverflowException for FSEvents overflow on macOS #130637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svick wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Raise InternalBufferOverflowException for FSEvents overflow on macOS #130637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecfbb15
Raise InternalBufferOverflowException for FSEvents overflow on macOS
svick Jul 13, 2026
f113fa8
Don't preserve eventFlags in exception HResult
svick Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.IO.FileSystem.Watcher/src/System/IO/FileSystemWatcher.OSX.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ private unsafe void ProcessEvents(int numEvents,
// First, we should check if this event should kick off a re-scan since we can't really rely on anything after this point if that is true
if (ShouldRescanOccur(eventFlags[i]))
{
watcher.OnError(new ErrorEventArgs(new IOException(SR.FSW_BufferOverflow, (int)eventFlags[i])));
watcher.OnError(new ErrorEventArgs(CreateBufferOverflowException(_fullDirectory)));
break;
Comment on lines 456 to 460
}
else if (handledRenameEvents == i)
Expand Down