Fix malformed parameters declaration in set-dry-run.yml#2160
Open
lbussell wants to merge 1 commit into
Open
Conversation
The parameters block used YAML map syntax, which defines parameters named 'name' and 'type' instead of a 'publishConfig' parameter. This broke callers passing publishConfig and the parameters.publishConfig.* references. Use the standard typed-list syntax. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mthalman
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a malformed
parameters:declaration ineng/docker-tools/templates/steps/set-dry-run.yml.The block used YAML map syntax:
Azure Pipelines interprets this as defining two parameters named
nameandtyperather than a singlepublishConfigparameter. This breaks the caller (templates/jobs/publish.yml), which passespublishConfig, and causes the in-template${{ parameters.publishConfig.PublishRegistry.repoPrefix }}reference to fail.The fix uses the standard typed-list syntax used throughout the other templates:
Context
This addresses the issue raised in #2159 (comment). PR #2159 moves the
eng/docker-toolsdirectory, but per request the fix is applied at the source-of-truth location undereng/docker-toolsinstead.Validation
reference-service-connections.yml,run-imagebuilder.yml).templates/jobs/publish.yml) passespublishConfig.