Couple minor fixes from previous refactors#5895
Open
hoyosjs wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies two small fixes after earlier refactors: one changes the visibility of the shared SOS package layout helper, and the other adjusts how the Windows runtime-install script invokes PowerShell/MSBuild.
Changes:
- Exposes
SOSPackageLayoutas apublictype (wasinternal) inSOS.Hosting. - Switches
eng/installruntimes.cmdfrompowershell -command "& ..."topowershell -File ...for invokingeng/common/msbuild.ps1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SOS/SOS.Hosting/SOSPackageLayout.cs | Changes SOSPackageLayout from internal to public, impacting API surface/type visibility. |
| eng/installruntimes.cmd | Updates PowerShell invocation style for running InstallRuntimes.proj. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// package base directory is the directory of the consuming assembly. | ||
| /// </summary> | ||
| internal static class SOSPackageLayout | ||
| public static class SOSPackageLayout |
max-charlamb
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.