Provide additional commentary on property pattern#1728
Merged
Conversation
`if (s is var x2)` and `if (s is {} x2)` look similar; this change explicitly notes the difference.
Definitely open to suggestions of changing where this occurs or how it's expressed. This felt like a minimalist change, which I *suspect* is all that's required.
Fixes #1653
BillWagner
approved these changes
Jul 14, 2026
BillWagner
left a comment
BillWagner
left a comment
Member
There was a problem hiding this comment.
This LGTM. I agree that it's a minimal change that fixes the issue.
Contributor
Author
|
Merging with just one review as it's so trivial. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if (s is var x2)andif (s is {} x2)look similar; this change explicitly notes the difference.Definitely open to suggestions of changing where this occurs or how it's expressed. This felt like a minimalist change, which I suspect is all that's required.
Fixes #1653