Harden wildcard matching with empty segments inside#67757
Open
cincuranet wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request hardens host wildcard matching to reject hosts containing empty DNS labels (consecutive dots) within the hostname, addressing issue #67756 (e.g., foo..example.com, foo..bar.example.com).
Changes:
- Updated
HostMatcherPolicywildcard host matching to reject request hosts that contain consecutive dots (..). - Updated
HostString.MatchesAnywildcard matching to also reject hosts containing consecutive dots. - Added test coverage for
foo..example.comandfoo..bar.example.comin both Routing integration tests andHostStringunit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Http/Routing/test/UnitTests/Matching/HostMatcherPolicyIntegrationTestBase.cs | Adds integration test cases ensuring wildcard host matching rejects hosts with empty labels inside (..). |
| src/Http/Routing/src/Matching/HostMatcherPolicy.cs | Adds .. rejection logic for wildcard host matching in both runtime matching paths. |
| src/Http/Http.Abstractions/test/HostStringTest.cs | Adds unit test cases ensuring HostString.MatchesAny rejects wildcard matches with empty labels inside. |
| src/Http/Http.Abstractions/src/HostString.cs | Adds .. rejection logic for subdomain wildcard matching in MatchesAny. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67756