Rename private static fields to use s_ prefix (part 1)#67730
Open
BekAllaev wants to merge 8 commits into
Open
Conversation
…art with s_ Add suffix to the private static fields in the Analyzers, Antiforgery/test, Caching, Components, DataProtection directories.
Moved trim_trailing_whitespace = false setting higher in the .editorconfig file for better organization. No functional changes were made.
Changed IDE0062 severity to silent in .editorconfig to suppress static local function suggestions. Added settings to enforce UTF-8 BOM and LF line endings for .received and .verified test files.
Changed charset to "utf-8-bom" and set trim_trailing_whitespace to false in .editorconfig. No other formatting properties were altered.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is part of the effort to standardize non-public static field naming across the repo by adopting the s_ prefix convention, and it updates both the style enforcement and many existing call sites accordingly.
Changes:
- Adds a root
.editorconfignaming rule requirings_forprivate/internal/private_protectedstatic fields. - Mechanically renames affected static fields to
s_camelCaseand updates references across multiple areas (Analyzers, Antiforgery tests, Caching, Components, DataProtection). - Updates various tests/samples to match the new convention.
Reviewed changes
Copilot reviewed 155 out of 155 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DataProtection/StackExchangeRedis/test/TestRedisServer.cs | Renames static configuration field to s_ prefix. |
| src/DataProtection/samples/KeyManagementSimulator/Program.cs | Renames static descriptor XML field to s_ prefix. |
| src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/XmlAssert.cs | Renames static comparer field to s_ prefix and updates usage. |
| src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/Repositories/RegistryXmlRepositoryTests.cs | Renames static lazy registry key field to s_ prefix and updates usages. |
| src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/RegistryPolicyResolverTests.cs | Renames static lazy registry key field to s_ prefix and updates usages. |
| src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/KeyManagement/XmlKeyManagerTests.cs | Renames static descriptor XML field to s_ prefix and updates mocks/usages. |
| src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/Internal/KeyManagementOptionsSetupTest.cs | Renames static lazy registry key field to s_ prefix and updates usages. |
| src/DataProtection/DataProtection/test/Microsoft.AspNetCore.DataProtection.Tests/ContainerUtilsTests.cs | Renames static fstab sample array to s_ prefix and updates tests. |
| src/DataProtection/DataProtection/src/XmlEncryption/XmlEncryptionExtensions.cs | Updates references to renamed XmlConstants static fields. |
| src/DataProtection/DataProtection/src/XmlConstants.cs | Renames non-public static XML name constants to s_ prefix. |
| src/DataProtection/DataProtection/src/SimpleActivator.cs | Renames static ctor parameter type array to s_ prefix and updates usage. |
| src/DataProtection/DataProtection/src/Repositories/RegistryXmlRepository.cs | Renames static lazy default key field to s_ prefix and updates property. |
| src/DataProtection/DataProtection/src/Repositories/DefaultKeyStorageDirectories.cs | Renames static lazy default directory field to s_ prefix and updates usage. |
| src/DataProtection/DataProtection/src/Managed/ManagedGenRandomImpl.cs | Renames static RNG field to s_ prefix and updates usage. |
| src/DataProtection/DataProtection/src/KeyManagement/KeyManagementOptions.cs | Renames static TimeSpan fields to s_ prefix and updates accessors. |
| src/DataProtection/DataProtection/src/Internal/ContainerUtils.cs | Renames static lazy container detection field to s_ prefix and updates property. |
| src/DataProtection/DataProtection/src/Cng/DpapiSecretSerializerHelper.cs | Renames static purpose byte[] to s_ prefix and updates unsafe fixed blocks. |
| src/DataProtection/DataProtection/src/AuthenticatedEncryption/ConfigurationModel/XmlExtensions.cs | Updates references to renamed XmlConstants fields. |
| src/DataProtection/DataProtection/src/AuthenticatedEncryption/ConfigurationModel/ManagedAlgorithmHelpers.cs | Renames static known-type list to s_ prefix and updates usages. |
| src/DataProtection/Cryptography.Internal/test/Cng/CachedAlgorithmHandlesTests.cs | Renames static test buffers to s_ prefix and updates fixed blocks. |
| src/DataProtection/Cryptography.Internal/src/Cng/OSVersionUtil.cs | Renames cached OS version field to s_ prefix and updates checks. |
| src/Components/WebView/WebView/test/Infrastructure/TestWebViewManager.cs | Renames static base URI field to s_ prefix and updates URI construction. |
| src/Components/WebView/WebView/src/StaticContentProvider.cs | Renames static content-type provider to s_ prefix and updates usage. |
| src/Components/WebView/WebView/src/Services/WebViewRenderer.cs | Renames static RendererInfo field to s_ prefix and updates override. |
| src/Components/WebView/Samples/PhotinoPlatform/src/PhotinoSynchronizationContext.cs | Renames static thunk delegates to s_ prefix and updates continuations/ExecutionContext.Run. |
| src/Components/WebAssembly/WebAssembly/test/PullFromJSDataStreamTest.cs | Renames static runtime/data fields to s_ prefix and updates test usages. |
| src/Components/WebAssembly/WebAssembly/src/Services/WebAssemblyConsoleLogger.cs | Renames static padding/builder fields to s_ prefix and updates locking/message formatting. |
| src/Components/WebAssembly/WebAssembly/src/Rendering/WebAssemblyRenderer.cs | Renames static RendererInfo field to s_ prefix and updates override. |
| src/Components/WebAssembly/WebAssembly/src/Http/WebAssemblyHttpRequestMessageExtensions.cs | Renames static HttpRequestOptionsKey fields to s_ prefix and updates option access. |
| src/Components/WebAssembly/WebAssembly/src/Hosting/WebAssemblyCallQueue.cs | Renames static queue state fields to s_ prefix and updates scheduling logic. |
| src/Components/WebAssembly/WebAssembly.Authentication/test/RemoteAuthenticatorCoreTests.cs | Renames static dispatcher field to s_ prefix and updates override. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/Services/RemoteAuthenticationService.cs | Renames static cache refresh interval to s_ prefix and updates usage. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/Services/DeserializedAuthenticationStateProvider.cs | Renames static unauthenticated task to s_ prefix and updates initialization. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/RemoteAuthenticatorViewCore.cs | Renames static navigation options to s_ prefix and updates all NavigateTo calls. |
| src/Components/WebAssembly/WebAssembly.Authentication/src/Options/AuthenticationStateDeserializationOptions.cs | Renames static default unauthenticated state task to s_ prefix and updates usage. |
| src/Components/WebAssembly/Server/src/TargetPickerUi.cs | Renames static JSON options to s_ prefix and updates deserialization. |
| src/Components/WebAssembly/Server/src/DebugProxyLauncher.cs | Renames multiple static fields (locks/timeouts/regexes/etc.) to s_ prefix and updates usages. |
| src/Components/WebAssembly/Server/src/ContentEncodingNegotiator.cs | Renames static encoding preferences/maps to s_ prefix and updates negotiation logic. |
| src/Components/WebAssembly/Samples/HostedBlazorWebassemblyApp/Server/Data/WeatherForecastService.cs | Renames static summaries array to s_ prefix and updates selection logic. |
| src/Components/Web/src/WebEventData/WheelEventArgsReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/WebEventDescriptorReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/ProgressEventArgReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/PointerEventArgsReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/KeyboardEventArgsReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/FocusEventArgsReader.cs | Renames static JsonEncodedText key to s_ prefix and updates comparison. |
| src/Components/Web/src/WebEventData/ErrorEventArgsReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/DragEventArgsReader.cs | Renames static JsonEncodedText keys to s_ prefix and updates comparisons. |
| src/Components/Web/src/WebEventData/ClipboardEventArgsReader.cs | Renames static JsonEncodedText key to s_ prefix and updates comparison. |
| src/Components/Web/src/WebEventData/ChangeEventArgsReader.cs | Renames static JsonEncodedText key to s_ prefix and updates comparison. |
| src/Components/Web/src/Routing/NavLink.cs | Renames static switch/comparer fields to s_ prefix and updates matching logic. |
| src/Components/Web/src/JSComponents/JSComponentInterop.cs | Renames static cache dictionary to s_ prefix and updates hot reload hook/usages. |
| src/Components/Web/src/HtmlRendering/StaticHtmlRenderer.HtmlWriting.cs | Renames static element set/context info to s_ prefix and updates usage. |
| src/Components/Web/src/HtmlRendering/StaticHtmlRenderer.cs | Renames static RendererInfo field to s_ prefix and updates override. |
| src/Components/Web/src/Forms/Mapping/EditContextFormMappingExtensions.cs | Renames static properties key object to s_ prefix and updates access. |
| src/Components/Web/src/Forms/InputNumber.cs | Renames static step attribute value to s_ prefix and updates render output. |
| src/Components/Web/src/Forms/FieldIdGenerator.cs | Renames static invalid-char set to s_ prefix and updates checks. |
| src/Components/Web/src/Forms/ExpressionMemberAccessor.cs | Renames static caches to s_ prefix and updates cache access/clear. |
| src/Components/Web/src/Forms/EditContextFieldClassExtensions.cs | Renames static provider key object to s_ prefix and updates access. |
| src/Components/test/testassets/Components.TestServer/PauseTrackingHandler.cs | Renames static circuits dictionary to s_ prefix and updates access. |
| src/Components/test/testassets/BasicTestApp/VirtualizationAnchorModeWindowScroll.razor | Renames static item comparer to s_ prefix and updates component attribute. |
| src/Components/test/testassets/BasicTestApp/VirtualizationAnchorMode.razor | Renames static item comparer to s_ prefix and updates component attribute. |
| src/Components/test/testassets/BasicTestApp/MediaTest/ImageTestComponent.razor | Renames static test media data buffers to s_ prefix and updates media sources. |
| src/Components/test/testassets/BasicTestApp/MediaTest/FileDownloadTestComponent.razor | Renames static test media data buffers to s_ prefix and updates media sources/streams. |
| src/Components/test/E2ETest/ServerExecutionTests/AutoPauseDeferralTests.cs | Renames static timeouts/windows to s_ prefix and updates deadline/exception text. |
| src/Components/test/E2ETest/Infrastructure/ServerFixtures/ServerFixture.cs | Renames static lazy projects map to s_ prefix and updates access. |
| src/Components/Shared/src/UrlValueConstraint.cs | Renames static cached instances dictionary to s_ prefix and updates access. |
| src/Components/Shared/src/Reflection/PropertySetter.cs | Renames static open-generic MethodInfo to s_ prefix and updates usage. |
| src/Components/Shared/src/Reflection/PropertyGetter.cs | Renames static open-generic MethodInfo to s_ prefix and updates usage. |
| src/Components/Shared/src/ElementReferenceJsonConverter.cs | Renames static JsonEncodedText property name to s_ prefix and updates read/write. |
| src/Components/Shared/src/ArrayBuilder.cs | Renames static empty array field to s_ prefix and updates buffer handling. |
| src/Components/Server/test/Circuits/RemoteJSDataStreamTest.cs | Renames static JS runtime to s_ prefix and updates test helpers/usages. |
| src/Components/Server/test/Circuits/CircuitPersistenceManagerTest.cs | Renames static serializer options to s_ prefix and updates deserialization. |
| src/Components/Server/src/ComponentHub.cs | Renames static context items key to s_ prefix and updates registry access. |
| src/Components/Server/src/Circuits/RemoteRenderer.cs | Renames static canceled task/platform info to s_ prefix and updates overrides/returns. |
| src/Components/Server/src/Circuits/HybridCacheCircuitPersistenceProvider.cs | Renames static factory/tags to s_ prefix and updates cache calls. |
| src/Components/Server/src/Circuits/DefaultInMemoryCircuitPersistenceProvider.cs | Renames static “no match” task to s_ prefix and updates returns. |
| src/Components/Server/src/BlazorPack/SequenceOfT.cs | Renames static defaults/value-type flag to s_ prefix and updates usage. |
| src/Components/Samples/BlazorUnitedApp/Data/WeatherForecastService.cs | Renames static summaries array to s_ prefix and updates selection logic. |
| src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/test/GridSortTest.cs | Renames static empty item arrays to s_ prefix and updates queryable setup. |
| src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/Infrastructure/AsyncQueryExecutorSupplier.cs | Renames static provider-type cache to s_ prefix and updates lookups. |
| src/Components/QuickGrid/Microsoft.AspNetCore.Components.QuickGrid/src/Columns/TemplateColumn.cs | Renames static empty child content fragment to s_ prefix and updates default parameter. |
| src/Components/Media/test/ImageTest.cs | Renames static PNG bytes to s_ prefix and updates test usage. |
| src/Components/Media/test/FileDownloadTest.cs | Renames static sample bytes to s_ prefix and updates helper/parameter setup. |
| src/Components/Forms/test/EditContextAsyncTest.cs | Renames static timeout to s_ prefix and updates waits/time checks. |
| src/Components/Forms/src/FieldIdentifier.cs | Renames static accessor cache to s_ prefix and updates cache access/clear. |
| src/Components/Forms/src/EditContextDataAnnotationsExtensions.cs | Renames static property-info cache to s_ prefix and updates access/clear. |
| src/Components/Forms/src/ClientValidation/ClientValidationRule.cs | Renames static empty parameters map to s_ prefix and updates getter. |
| src/Components/Endpoints/test/RenderFragmentSerializerTest.cs | Renames static logger/options/cache to s_ prefix and updates usages. |
| src/Components/Endpoints/test/RazorComponentsServiceCollectionExtensionsTest.cs | Renames static reflected type field to s_ prefix and updates dictionary key usage. |
| src/Components/Endpoints/test/RazorComponentResultTest.cs | Renames static regexes to s_ prefix and updates masking logic. |
| src/Components/Endpoints/test/EndpointHtmlRendererTest.cs | Renames static data protection provider to s_ prefix and updates all usages. |
| src/Components/Endpoints/src/TempData/TempDataCascadingValueSupplier.cs | Renames static property getter cache to s_ prefix and updates GetOrAdd. |
| src/Components/Endpoints/src/SessionCascadingValueSupplier.cs | Renames static cache/options to s_ prefix and updates serialization/deserialization. |
| src/Components/Endpoints/src/Results/RazorComponentResult.cs | Renames static empty-parameters map to s_ prefix and updates assignment. |
| src/Components/Endpoints/src/Rendering/SSRRenderModeBoundary.cs | Renames static type-hash cache to s_ prefix and updates marker key generation. |
| src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.PrerenderingState.cs | Renames static HttpContext items key to s_ prefix and updates access. |
| src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.Prerendering.cs | Renames static HttpContext items key to s_ prefix and updates access. |
| src/Components/Endpoints/src/Rendering/EndpointComponentState.cs | Renames static attribute cache to s_ prefix and updates hot reload hooks/access. |
| src/Components/Endpoints/src/FormMapping/HttpContextFormValueMapper.cs | Renames static deserializer cache to s_ prefix and updates GetOrAdd. |
| src/Components/Endpoints/src/FormMapping/Converters/DictionaryConverter.cs | Renames static element type to s_ prefix and updates converter calls. |
| src/Components/Endpoints/src/FormMapping/Converters/CollectionConverter.cs | Renames static element type/index array to s_ prefix and updates converter calls. |
| src/Components/Endpoints/src/DependencyInjection/PrerenderingErrorBoundaryLogger.cs | Renames static log message delegate to s_ prefix and updates invocation. |
| src/Components/Endpoints/src/Builder/RazorComponentsEndpointHttpContextExtensions.cs | Renames static interactive-routing cache to s_ prefix and updates clear/get. |
| src/Components/Endpoints/src/Builder/RazorComponentEndpointFactory.cs | Renames static HttpMethods metadata to s_ prefix and updates builder metadata. |
| src/Components/Endpoints/src/BrowserConfiguration/BrowserOptionsHttpContextExtensions.cs | Renames static HttpContext items key to s_ prefix and updates access. |
| src/Components/Components/test/RendererTest.cs | Renames static timeout to s_ prefix and updates wait calls. |
| src/Components/Components/test/NavigationManagerTest.cs | Renames static timeout to s_ prefix and updates WaitAsync calls. |
| src/Components/Components/test/ComponentBaseTest.cs | Renames static timeout to s_ prefix and updates wait calls. |
| src/Components/Components/src/Sections/SectionOutlet.cs | Renames static empty fragment to s_ prefix and updates usage. |
| src/Components/Components/src/Routing/RouteTable.cs | Renames static route entry cache to s_ prefix and updates hot reload hook/access. |
| src/Components/Components/src/RouteView.cs | Renames static layout cache to s_ prefix and updates lookup. |
| src/Components/Components/src/RenderTree/EventArgsTypeCache.cs | Renames static cache to s_ prefix and updates hot reload hook/access. |
| src/Components/Components/src/Rendering/RenderTreeBuilder.cs | Renames static boxed bool/message fields to s_ prefix and updates attribute handling/throws. |
| src/Components/Components/src/Reflection/ComponentProperties.cs | Renames static writers cache to s_ prefix and updates access/clear. |
| src/Components/Components/src/PersistentState/PersistentValueProviderComponentSubscription.cs | Renames static caches/sentinel to s_ prefix and updates access/sentinel comparisons. |
| src/Components/Components/src/PersistentState/PersistentStateValueProviderKeyResolver.cs | Renames static key cache to s_ prefix and updates access/clear. |
| src/Components/Components/src/PersistentState/PersistentServicesRegistry.cs | Renames static registry key/type cache/accessor cache to s_ prefix and updates usage. |
| src/Components/Components/src/ParameterView.cs | Renames static empty frames/empty view to s_ prefix and updates clone/Empty. |
| src/Components/Components/src/NavigationManagerExtensions.cs | Renames static formatter map to s_ prefix and updates lookups. |
| src/Components/Components/src/LayoutView.cs | Renames static empty fragment to s_ prefix and updates usage. |
| src/Components/Components/src/DefaultComponentPropertyActivator.cs | Renames static activator cache to s_ prefix and updates access/clear. |
| src/Components/Components/src/DefaultComponentActivator.cs | Renames static factory cache to s_ prefix and updates access/clear. |
| src/Components/Components/src/ComponentFactory.cs | Renames static switch/cache to s_ prefix and updates cache usage/injection toggle. |
| src/Components/Components/src/ChangeDetection.cs | Renames static immutable-type cache to s_ prefix and updates hot reload hook/access. |
| src/Components/Components/src/CascadingParameterState.cs | Renames static infos cache to s_ prefix and updates access. |
| src/Components/Components/src/BindConverter.cs | Renames static boxed bool/cache dictionaries to s_ prefix and updates hot reload hook/access. |
| src/Components/Authorization/test/AuthorizeViewTest.cs | Renames static timeout field to s_ prefix and updates wait calls. |
| src/Components/Authorization/test/AuthorizeRouteViewTest.cs | Renames static empty parameters dictionary to s_ prefix and updates test setup. |
| src/Components/Authorization/src/AuthorizeRouteView.cs | Renames static default fragments to s_ prefix and updates fallback selection. |
| src/Components/Authorization/src/AttributeAuthorizeDataCache.cs | Renames static authorize-data cache to s_ prefix and updates access/clear. |
| src/Components/Analyzers/test/VirtualizeItemComparerAnalyzerTest.cs | Renames static declaration string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/SupplyParameterFromFormAnalyzerTest.cs | Renames static declarations string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/StateHasChangedCodeFixProviderTest.cs | Renames static declarations string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/StateHasChangedAnalyzerTest.cs | Renames static declarations string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/PersistentStateAnalyzerTest.cs | Renames static declarations string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/InvokeAsyncOfObjectAnalyzerTest.cs | Renames static JS interop declarations string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/Helpers/DiagnosticVerifier.Helper.cs | Renames static metadata refs/default strings to s_ prefix and updates project setup. |
| src/Components/Analyzers/test/AuthenticationStateProviderAnalyzerTest.cs | Renames static declarations string to s_ prefix and updates concatenations. |
| src/Components/Analyzers/test/AnalyzerTestBase.cs | Renames static base directory to s_ prefix and updates path composition. |
| src/Components/Analyzers/src/StateHasChangedCodeFixProvider.cs | Renames static title to s_ prefix and updates ToString usage. |
| src/Components/Analyzers/src/ComponentParametersShouldBePublicCodeFixProvider.cs | Renames static title to s_ prefix and updates ToString usage. |
| src/Components/Analyzers/src/ComponentInternalUsageDiagnosticAnalzyer.cs | Renames static namespace parts array to s_ prefix and updates iteration/comparison. |
| src/Caching/StackExchangeRedis/test/Infrastructure/RedisTestConfig.cs | Renames static process/lock fields to s_ prefix and updates locking/process management. |
| src/Caching/StackExchangeRedis/src/RedisCache.cs | Renames static RedisValue arrays to s_ prefix and updates selector. |
| src/Caching/SqlServer/src/SqlServerCache.cs | Renames static intervals to s_ prefix and updates validation/defaulting. |
| src/Antiforgery/test/DefaultAntiforgeryTokenSerializerTest.cs | Renames static test blobs to s_ prefix and updates token setup. |
| src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/DiagnosticProject.cs | Renames static resolver/cache to s_ prefix and updates locking/resolution. |
| src/Analyzers/Analyzers/test/StartupFactsTest.cs | Renames static test source dictionary to s_ prefix and updates compilation creation. |
| .editorconfig | Adds naming rule enforcing s_ prefix for non-public static fields. |
| // Nothing should exceed the timeout in a successful run of the the tests, this is just here to catch | ||
| // failures. | ||
| private static readonly TimeSpan Timeout = Debugger.IsAttached ? System.Threading.Timeout.InfiniteTimeSpan : TimeSpan.FromSeconds(10); | ||
| private static readonly TimeSpan s_timeout = Debugger.IsAttached ? System.Threading.s_timeout.InfiniteTimeSpan : TimeSpan.FromSeconds(10); |
Updated s_timeout to use System.Threading.Timeout.InfiniteTimeSpan instead of the incorrect System.Threading.s_timeout.InfiniteTimeSpan, ensuring the correct constant is used for infinite timeouts.
Contributor
Author
|
@dotnet-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename private static fields to use the
s_prefixDescription
This is the first in a planned series of scoped PRs addressing #50888.
Per the team decision to adopt the
s_prefix convention for non-public static fields (as confirmed here), this PR:s_naming rule for private/internal/private_protected static fields to the root.editorconfig(severitysuggestion).s_camelCasein the following areas:AnalyzersAntiforgery(tests)CachingComponentsDataProtectionThe rule follows the convention used in
dotnet/runtimeanddotnet/aspire, so it applies toprivate,internal, andprivate_protectedstatic fields.Here are the changes I've made for today. I initially considered keeping the PR small, since that would make it easier to review - but the total number of files that need to change across the whole issue is enormous (around 1000), and splitting that into many tiny PRs wouldn't make much sense either. So I decided to cover as many areas as I could in one pass, given that it's a straightforward mechanical rename. This PR touches 155 files across
Analyzers,Antiforgery/tests,Caching,Components, andDataProtectiondirectories. If reviewers would prefer smaller PRs, I'm happy to split this one up by area.Fixes partially #50888