Narrow broad catch (Exception) in AndroidBuildToolsVersion.TryParse#11661
Draft
Copilot wants to merge 2 commits into
Draft
Narrow broad catch (Exception) in AndroidBuildToolsVersion.TryParse#11661Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix empty catch block in AndroidBuildToolsVersion.TryParse
Narrow broad catch (Exception) in AndroidBuildToolsVersion.TryParse
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AndroidBuildToolsVersion.TryParsewrapped its parse logic in an empty, undocumentedcatch (Exception), silently swallowing every exception type — including genuinely unexpected ones — making real bugs indistinguishable from an expected "bad version string" result.Changes
src/Xamarin.AndroidTools/AndroidBuildToolsVersion.cs: Replace the barecatch (Exception)with the three specific types the parse path can actually produce, each documented:Why these three are exhaustive
ParseInternal→MonoDroidSdk.ParseVersiononly callsint.Parse(FormatException/OverflowException) andnew Version (...)(ArgumentOutOfRangeException, a subclass ofArgumentException). Catching theArgumentExceptionbase rather than the narrower derived type is intentional defensiveness.return falsesemantics are preserved exactly for malformed strings ("abc","1.x","-1.0","99999999999999999999"); unexpected exceptions now propagate instead of being hidden. No method signatures changed; no other files touched.