Bump external/Java.Interop from b881d21 to cfca8ad#11622
Open
dependabot[bot] wants to merge 11 commits into
Open
Bump external/Java.Interop from b881d21 to cfca8ad#11622dependabot[bot] wants to merge 11 commits into
b881d21 to cfca8ad#11622dependabot[bot] wants to merge 11 commits into
Conversation
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to `d7dbad5`. - [Commits](dotnet/java-interop@b881d21...d7dbad5) --- updated-dependencies: - dependency-name: external/Java.Interop dependency-version: d7dbad5e30a8f03743a508a95c4e9159fe1f6607 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Use the new ReflectionJniTypeManager and ReflectionJniValueManager bases introduced by the Java.Interop submodule update, while preserving Android's legacy peer activation path for value managers. Also keep Java.Interop built-in native registrations out of the trimmable typemap XA4251 path and remove the stale GenericMarshaler source include from Android Java.Interop tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Keep reflection-manager analyzer suppressions local to Mono.Android build compilation so NativeAOT app warning tests still observe the expected warnings. Isolate post-trim trimmable typemap Java output per inner build to avoid concurrent linked-java cleanup races, and update the MonoVM APK size baseline for the Java.Interop bump. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Member
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Resolve the Java.Interop test project conflict by keeping the NUnit package reference from main while dropping the stale GenericMarshaler source include removed for the Java.Interop update. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Keep the Java.Interop reflection-manager compatibility suppressions limited to trim analysis warnings so AOT warning-count tests still observe expected IL3050/IL3053 output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Account for the additional temporary reflection-manager trim warnings emitted by the Java.Interop update while preserving AOT warning visibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5a6cb51 to
6a34c90
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
b881d21 to d7dbad5b881d21 to cfca8ad
…bump After bumping external/Java.Interop to cfca8ad, the apkdiff regression test BuildReleaseArm64(False,MonoVM) fails because lib_System.Private.CoreLib.dll.so grew ~10% and lib_Java.Interop.dll.so grew ~5.5%, both exceeding the 5% content regression threshold. Refresh the reference apkdesc with the actual sizes captured by the CI run (build 1462159). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
A newer version of external/Java.Interop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simonrozsival
added a commit
to dotnet/java-interop
that referenced
this pull request
Jun 15, 2026
#1441 added `JniRuntime.JniTypeManager.TryRegisterBuiltInNativeMembers ()` -- a reflection-free direct call to `JavaProxyObject.RegisterNativeMembers` -- and bumped that method to `internal` so the call would compile. That method is dead code: nothing in Java.Interop (or dotnet/android) ever calls it, and the base `JniTypeManager.RegisterNativeMembers` is a no-op. `JavaProxyObject`'s native members are -- and were before #1441 -- registered purely via reflection in `ReflectionJniTypeManager` (`FindAndCallRegisterMethod` discovering the `[JniAddNativeMethodRegistrationAttribute]`-annotated method), which finds private methods just fine via `GetRuntimeMethods ()`. Remove the unused `TryRegisterBuiltInNativeMembers` and restore `RegisterNativeMembers` to `private` (its state before #1441). Making it private again also strips the attribute-bearing method from the reference assembly, which fixes dotnet/android's trimmable typemap scanner falsely rejecting the built-in `JavaProxyObject` with XA4251 (dotnet/android#11622). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps external/Java.Interop from
b881d21tocfca8ad.Commits:
cfca8adUpgrade gh-aw to v0.79.6 and recompile workflows (#1460)0104236[JniValueManager] Make TryConstructPeer virtual (#1456)d7dbad5Remove Java.Interop.Dynamic (#1449)0244c10Split reflection-based JniTypeManager and JniValueManager behavior (#1441)9ca7064[Java.Interop] Remove legacyNETpreprocessor paths (#1451)cd2fc12Remove Java.Interop.GenericMarshaler (#1450)See full diff in compare view.