docs(clustering): correct the stale server-heartbeat interval comment - #37014
Open
dsolistorres wants to merge 1 commit into
Open
docs(clustering): correct the stale server-heartbeat interval comment#37014dsolistorres wants to merge 1 commit into
dsolistorres wants to merge 1 commit into
Conversation
Contributor
|
Claude finished @dsolistorres's task in 24s —— View job Code Review
New IssuesNo issues found. This is a comment-only change with no behavior impact. The correction is accurate:
Both defaults are Nothing to test — no runtime path changed. |
5 tasks
SERVER_HEARTBEAT_RUN_EVERY_SECONDS defaults to 60, but the trailing comment read "runs every 5 seconds." The comment was wrong from the moment it was written, not left behind by a later change of default. Commit 9990360 (#19291, unifying the three quartz schedulers) introduced this block by adapting the SystemEventsJob block ~150 lines above, which does default to 5 seconds and carries that exact comment; the property name and default were changed to 60 and the comment was not. The cadence itself never changed either. Before that commit the heartbeat was a Quartz CronTrigger on HEARTBEAT_CRON_EXPRESSION, defaulted to "0 0/1 * * * ?" in dotcms-config-cluster.properties -- once a minute. The 60-second fixed delay preserved it. Replaced with a note on what the interval actually governs, since it bounds how quickly a node notices a membership change or retries a failed cache-transport rewire (#36803). Comment only; no behaviour change.
dsolistorres
force-pushed
the
fix-stale-heartbeat-interval-comment
branch
from
August 12, 2026 01:37
193ce79 to
840636b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #37015.
SERVER_HEARTBEAT_RUN_EVERY_SECONDSdefaults to 60, but the trailing comment read// runs every 5 seconds.Why it was wrong
Not a default that changed and left the comment behind — the comment was wrong when it was written.
999036092e(#19291, unifying the 3 quartz schedulers, Oct 2020) created this block by adapting theSystemEventsJobblock ~150 lines above:That one is correct — it really does default to 5. The heartbeat copy changed the property name and the default to 60 and kept the comment verbatim.
The cadence never changed either. Before that commit the heartbeat was a Quartz
CronTriggeronHEARTBEAT_CRON_EXPRESSION, defaulted to0 0/1 * * * ?indotcms-config-cluster.properties— once a minute. The 60-second fixed delay preserved it; only the mechanism changed.Testing
Comment only, no behaviour change — nothing to test. Found while tracing the heartbeat cadence for #36803, where this interval bounds how quickly a failed cache-transport rewire is retried.
🤖 Generated with Claude Code