Issue 36702 asset picker

[nicobytes]

This pull request introduces a set of improvements and refactorings to the folder tree utilities and related data-access APIs, aimed at enhancing code reuse, maintainability, and consistency across the Content Drive and Host Folder Field features. The changes include moving folder tree logic into shared utilities, updating service providers, and aligning data models.

Core refactoring and utility extraction:

• Introduced new shared utilities folder-tree.utils.ts and folder-tree-load.utils.ts in @dotcms/data-access, centralizing the logic for building, loading, and paginating folder trees. This includes new functions such as generateAllParentPaths, createTreeNode, and buildTreeFolderNodes, as well as utilities for paginated loading and "Load more" node handling. [1] [2]

API and provider updates:

• Updated DotContentDriveService to use Angular's providedIn: 'root' for global availability, and removed it from route-level providers. This ensures the service can be used from dialogs and other contexts without explicit injection in every route. [1] [2]

Imports and dependency cleanup:

• Updated imports in various portlet files to use the new shared utilities from @dotcms/data-access instead of local utility definitions, and cleaned up duplicate or outdated imports for components such as DotFolderListViewComponent. [1] [2] [3] [4]

Data model alignment:

• Extended the TreeNodeContentData model to include additional metadata fields (inode, defaultBaseType, fromTable) for improved folder selection and upload behavior in the Content Drive and AssetPicker.

Constants and type re-exports:

• Refactored and re-exported shared folder tree page size constants from the new utilities, ensuring consistent pagination limits across features, and deprecated local type definitions in favor of those from @dotcms/data-access. [1] [2] [3] [4]

These changes improve code maintainability, reduce duplication, and ensure that folder tree behaviors remain consistent across all consuming features.

This PR fixes: #36702

AssetPicker series — all seven sub-issues are resolved in this PR:

Fixes #36831 — AssetPicker 1/7: Migrate DotFolderListView to @dotcms/ui
Fixes #36832 — AssetPicker 2/7: Lift folder-tree helpers and harden drive data-access
Fixes #36833 — AssetPicker 3/7: Decouple Content Drive toolbar chrome for AssetPicker reuse
Fixes #36834 — AssetPicker 4/7: Headless browse store (no URL) for AssetPicker
Fixes #36835 — AssetPicker 5/7: Build DotAssetPicker shell in @dotcms/ui
Fixes #36836 — AssetPicker 6/7: File/Image entry configs, silent mime, CT limits, global last path
Fixes #36837 — AssetPicker 7/7: Wire AssetPicker into Edit Content File/Image fields

[claude]

Claude finished @nicobytes's task in 2m 35s —— View job

---

Claude PR Review

I re-checked every prior review finding (Copilot + @adrianjm-dotCMS) against the current HEAD and looked for new issues introduced by the diff. The store/feature files now carry detailed comments that map one-to-one onto the earlier findings, and the File/Image field wiring is present. Summary below.

New Issues

No new blocking issues found in the diff.

Existing

• 🟡 Medium: core-web/libs/data-access/src/lib/dot-folder/folder-tree.utils.ts:96 — isLeaf = (levelIndex) => folderHierarchyLevels.length >= levelIndex + 1 is true for every level, so every on-target-path node is marked leaf, hiding the expand toggle on ancestors that actually have children (Copilot's earlier note). However, this logic is carried over verbatim from dot-content-drive/.../utils/tree-folder.utils.ts on origin/main — it's a pre-existing bug in the Content Drive path, not a regression introduced here, and the AssetPicker doesn't use buildTreeFolderNodes (it goes through site-tree.utils + buildTreeByPaths). Worth fixing while the code is being relocated, but not a merge blocker. Correct predicate would be levelIndex + 1 === folderHierarchyLevels.length. Fix this →

Resolved

• ✅ store/features/with-asset-folder-tree.feature.ts:272-337 — folder-load error masking is fixed: success work lives in tap before catchError, and catchError returns EMPTY (not of([])), so a failure sets ERROR and can never be patched back to LOADED.
• ✅ store/features/with-asset-folder-tree.feature.ts:153-159 — the browsed site no longer vanishes when the search term matches a folder but not the hostname: existingRoot ?? browsingService.mapSiteToTreeNode(site) re-inserts it into roots.
• ✅ store/features/with-asset-folder-tree.feature.ts:315-324 — TreeLoadResult's "absent selectedNode = leave highlight alone" contract is honored via conditional spread ...(selectedNode !== undefined ? { selectedNode } : {}).
• ✅ store/dot-asset-picker.store.ts:140-153 — free-text search now calls store.selectRootNode() after dropping path, so the tree highlight (and $targetFolder upload destination) follows the site-wide scope instead of pointing at a stale folder.
• ✅ store/features/with-asset-browse.feature.ts:135-145 — loadItems clears selectedAsset when a new request starts, so Confirm can't stay enabled for a row that scrolled out of the list.
• ✅ components/dot-asset-picker-toolbar/dot-asset-picker-toolbar.component.ts:57-63 — $allowedBaseTypes reads config.allowedBaseTypes (not baseTypes), so File mode still restricts the selector to DOTASSET/FILEASSET while starting with no selection.
• ✅ dot-asset-picker.component.ts:176-198 — confirm()'s getContentletByInodeWithContent subscription now has an error: handler (toast + dialog stays open), matching #uploadByBaseType.
• ✅ ui/src/index.ts / dot-file-field.component.ts:838-920 — the AssetPicker is now wired into the File/Image field: showSelectExistingFileDialog() → #openAssetPicker(site) opens DotAssetPickerComponent with buildAssetPickerConfig({ mode, site, title, languageId }), replacing the legacy DotBrowserSelectorComponent.
• ✅ dot-asset-picker.component.html:33 — double-click binds to onSelect([$event]) (select only). This is a deliberate design choice documented in the component header ("double-clicking a row selects it rather than opening an editor… confirming stays an explicit action"), diverging from Copilot's reading of the AC. Flagging for product awareness, not as a defect.

Nice work — the inline comments explaining each of these decisions made the recheck straightforward.
· issue-36702-asset-picker

• Gather context (diff, key files)
• Recheck prior review findings
• Review new/changed code for bugs, security, conventions
• Post review

[Copilot]

Pull request overview

This PR refactors the existing Folder List View used by Content Drive into a reusable presentational component in @dotcms/ui, adding a single-selection mode intended for the upcoming AssetPicker (while preserving current Content Drive behavior via the default multiple selection mode).

Changes:

• Moved Folder List View domain-agnostic types/constants into @dotcms/ui and re-exported them from the Content Drive UI package for compatibility.
• Added selectionMode: 'single' | 'multiple' support to the table (checkboxes in multiple mode, radios in single mode) and normalized emitted selections to an array.
• Updated Content Drive shell imports and updated/extended unit tests accordingly.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
core-web/libs/ui/src/lib/components/dot-folder-list-view/models.ts	Introduces shared column typing and selectionMode model for the Folder List View.
core-web/libs/ui/src/lib/components/dot-folder-list-view/constants.ts	Defines header column config and drag MIME type local to the component folder.
core-web/libs/ui/src/lib/components/dot-folder-list-view/mocks.ts	Moves test mocks alongside the component.
core-web/libs/ui/src/lib/components/dot-folder-list-view/dot-folder-list-view.component.ts	Adds selectionMode input, normalizes selection output, and updates internal imports to local UI sources.
core-web/libs/ui/src/lib/components/dot-folder-list-view/dot-folder-list-view.component.html	Switches checkbox vs radio rendering based on selectionMode and updates selection binding.
core-web/libs/ui/src/lib/components/dot-folder-list-view/dot-folder-list-view.component.scss	Fixes relative SCSS imports to match the libs layout.
core-web/libs/ui/src/lib/components/dot-folder-list-view/dot-folder-list-view.component.spec.ts	Updates tests for the new selection model and adds coverage for single-selection behavior.
core-web/libs/ui/src/index.ts	Exposes Folder List View component + related models/constants from @dotcms/ui.
core-web/libs/portlets/dot-content-drive/ui/src/lib/shared/models.ts	Removes Folder List View column typing now owned by @dotcms/ui.
core-web/libs/portlets/dot-content-drive/ui/src/lib/shared/constants.ts	Removes list-view constants now owned by @dotcms/ui.
core-web/libs/portlets/dot-content-drive/ui/src/index.ts	Re-exports the Folder List View API surface from @dotcms/ui for Content Drive consumers.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/dot-content-drive-shell/dot-content-drive-shell.component.ts	Updates imports to use @dotcms/ui for the presentational list component/types.
core-web/libs/portlets/dot-content-drive/portlet/src/lib/dot-content-drive-shell/dot-content-drive-shell.component.spec.ts	Aligns test imports with the updated component export location.

[Copilot]

Pull request overview

Copilot reviewed 76 out of 78 changed files in this pull request and generated no new comments.

Suppressed comments (1)

core-web/libs/ui/src/lib/components/dot-asset-picker/store/features/with-asset-folder-tree.feature.ts:97

• loadFolders sets foldersStatus to ERROR in catchError, but then the subscribe block unconditionally patches it back to LOADED (because catchError returns an empty array). This masks folder-tree failures and makes the UI indistinguishable from a successful empty tree.