warn on duplicate cache-to targets#3833
Open
areebahmeddd wants to merge 1 commit into
Open
Conversation
areebahmeddd
force-pushed
the
fix/same-cache-warning
branch
from
d6b052c to
0f098db
Compare
tonistiigi
reviewed
May 29, 2026
tonistiigi
left a comment
tonistiigi
left a comment
Member
There was a problem hiding this comment.
If added, this should be based on some primary values, eg. type=local,dest=, type=registry,ref=. Eg. if same ref is used with different mode then it is still a collision. And we shouldn't use the potentially secret values for comparison or log them anyway.
Does this work with target inheritance?
Contributor
Author
yea sure, i think using a helper func here is enough for comparing the destination key. creds/mode are ignored
yes, this runs after inheritance gets resolved so shared inherited cache-to values still trigger the warning |
areebahmeddd
force-pushed
the
fix/same-cache-warning
branch
from
0f098db to
6bb0e59
Compare
Signed-off-by: Areeb Ahmed <areebahmed0709@gmail.com>
areebahmeddd
force-pushed
the
fix/same-cache-warning
branch
from
ff46287 to
149dde6
Compare
Contributor
Author
|
gentle ping! @tonistiigi @crazy-max |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
closes #3819
ai model disclosure
used vscode copilot (claude sonnet 4.6) to understand the issue context and help generate a fix. changes were self-reviewed and verified via: