Skip to content

Added openj9 builds#248

Closed
smurfy wants to merge 1 commit into
docker-library:masterfrom
smurfy:openj9
Closed

Added openj9 builds#248
smurfy wants to merge 1 commit into
docker-library:masterfrom
smurfy:openj9

Conversation

@smurfy

@smurfy smurfy commented Oct 28, 2021

Copy link
Copy Markdown

Closes #247

Adds openj9 builds of tomcat based on ibm-semeru-runtimes

@PascalSchumacher

Copy link
Copy Markdown

Imho it would be great it this was updated to add Java 17 and merged.

@smurfy

smurfy commented Dec 17, 2021

Copy link
Copy Markdown
Author

It seems ibm-semeru-runtimes just added 17 images, this mr predates this. I will update the MR shortly.

@smurfy

smurfy commented Dec 17, 2021

Copy link
Copy Markdown
Author

Rebased and ran update.sh to pick up java 17 variants too

@TheWiresharkGuy

Copy link
Copy Markdown

Any news on this?

@PascalSchumacher

Copy link
Copy Markdown

It would be great if this was merged.

@tianon

tianon commented Nov 29, 2022

Copy link
Copy Markdown
Member

Sorry, our current "support matrix" is already out of control, so we're still trying to decide the best path forward. 🙇

To give you an idea the scale I'm talking about, we currently support four concrete versions of Tomcat across ~3 versions of Java (both JDK and JRE) on up to three different implementation+distro combinations. That's ~49 different builds of Tomcat, which is then multiplied by the list of supported architectures for each image we're FROM. 😬

If we take this PR to the extended conclusion, that balloons to ~6 versions of Java (again, ~two builds each, JDK and JRE), from ~5 vendors across even more variants -- I have a test branch that includes those full changes, and it takes the matrix of supported versions from 49 all the way up to 228 (which still doesn't factor in the way the matrix expands along the supported architectures axis -- that's just explicit tag combinations that all support at least amd64). Limiting that to just the three LTS versions of Java takes us down to 147, but that's still really unmanageable (even the 49 we're at now is pretty high up there). 😮‍💨

One thing we've considered is updating the templating to generate all 228 variants, but only officially build/publish one or two "tracks" (perhaps just Temurin, for example). That would take our actual supported list way down, but I wouldn't want to publish that many Dockerfiles unless our automated builds are also testing them, and at 228 we'd be pushing the limits of what GitHub Actions is willing to accept. 😱

So, as you can see, this isn't as simple as just merging this PR. 😞

@ptrecenti

ptrecenti commented Nov 29, 2022

Copy link
Copy Markdown

So @tianon, instead of supporting multiple matrices of java, tomcat, and vendors.
What do you think about providing a way for vendors to use this repository as of truth to guarantee the tomcat capabilities against releases managed by other people and organizations?

@tianon

tianon commented Nov 29, 2022

Copy link
Copy Markdown
Member

I'm sorry, I'm afraid I'm having trouble parsing what you mean -- can you elaborate on what concrete change you're proposing?

@tianon

tianon commented May 8, 2023

Copy link
Copy Markdown
Member

Thanks for the push (and for the implementation suggestions!! 🙇 ❤️); I'm going to close this now in order to consolidate into #299 😅

@tianon tianon closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide openj9 (ibm-semeru-runtimes) based builds

5 participants