Updated documentation for Convertigo 8.4.3#2675
Open
nicolas-albert wants to merge 1 commit into
Open
Conversation
yosifkit
reviewed
Jun 4, 2026
| -Dconvertigo.engine.billing.persistence.jdbc.password=[password for specified db user] \ | ||
| -Dconvertigo.engine.billing.persistence.jdbc.url=jdbc:mysql://mysql:3306/c8oAnalytics" \ | ||
| %%IMAGE%% | ||
| docker run -d --name C8O \ |
Member
There was a problem hiding this comment.
I'd recommend not removing the $ at the beginning of command lines in a console code block, since that lets the syntax highlighter know that the line should be highlighted like a command and not the output of a command (with the line-end backslashes letting it know to continue the command syntax).
yosifkit
reviewed
Jun 4, 2026
Comment on lines
-254
to
+351
| $ docker run -d --name C8O -e COOKIE_SAMESITE=lax -p 28080:28080 %%IMAGE%% | ||
| docker run -d –name C8O -e COOKIE_SAMESITE=lax -p 28080:28080 %%IMAGE%% |
Member
There was a problem hiding this comment.
There are a few instances like this one where an en dash is sneaking in where it does not make sense, like a command line (and one where it already has on L284/R381). Plus, this is incorrectly replacing a --name with -name even if the dash was the correct dash (-) and not en dash (–).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thx!