FIX: report the SOCKS frontend's outcomes to the health check - #26
Merged
Conversation
Health tracking was wired into the goproxy response hook only, so a proxy serving SOCKS alone never recorded anything: it started healthy and stayed healthy however many connections failed, and /health answered 200 regardless. The endpoint was a liveness check rather than a health one for that deployment. The frontend reports on what it was asked to do, which is reach the target: opening a tunnel is a success and failing to dial one is a failure. A client refused before the proxy tried to reach anything, by its password, its network or the port it asked for, records nothing, since that says something about the client rather than about this proxy's ability to reach the world. That leaves the two frontends counting slightly different things: the HTTP one still treats a 407 as a failure, inherited from the original health check, where the challenge may have come from an upstream proxy with stale credentials or from this proxy challenging its own client. The difference is documented rather than smoothed over, since changing it would change behaviour that is already deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Health tracking was wired into the goproxy response hook only, so a proxy serving SOCKS alone never recorded anything: it started healthy and stayed healthy however many connections failed, and /health answered 200 regardless. The endpoint was a liveness check rather than a health one for that deployment.
The frontend reports on what it was asked to do, which is reach the target: opening a tunnel is a success and failing to dial one is a failure. A client refused before the proxy tried to reach anything, by its password, its network or the port it asked for, records nothing, since that says something about the client rather than about this proxy's ability to reach the world.
That leaves the two frontends counting slightly different things: the HTTP one still treats a 407 as a failure, inherited from the original health check, where the challenge may have come from an upstream proxy with stale credentials or from this proxy challenging its own client. The difference is documented rather than smoothed over, since changing it would change behaviour that is already deployed.