feat: testbed rework to avoid the callback patterns#956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of the Rapier testbed. In particular, the testbed no longer owns the physics scene. So the example is responsible for running the render loop, making it much easier to write example that reacts to, e.g., physics events (like the sensor examples) by not having to register a callback on the testbed.
It also makes example generally more helpful since the user can see how the simulation is stepped directly from the example file (instead of having to dig into the testbed source code).
This makes the
Harnessfrom the testbed obsolete, and removed.This also remove the alternative physics backend (PhysX and Box2d) since these crates don’t seem to be maintained any more and keeping them just increase the maintainance burden.