chore: bump ic-canister-runtime to 0.2.3 to unblock canhttp on ic-cdk 0.20 - #11073
Open
claude[bot] wants to merge 4 commits into
Open
chore: bump ic-canister-runtime to 0.2.3 to unblock canhttp on ic-cdk 0.20#11073claude[bot] wants to merge 4 commits into
claude[bot] wants to merge 4 commits into
Conversation
The pinned ic-canister-runtime 0.2.0 (resolving to 0.2.1 in Cargo.lock) still depends on ic-cdk 0.19, so canhttp and everything that depends on it stayed stuck on ic-cdk 0.19 even after other direct dependents moved to 0.20. ic-canister-runtime 0.2.3 (latest on crates.io) depends on ic-cdk ^0.20.1, so bumping the pin here lets those crates resolve onto ic-cdk 0.20. Cargo.lock is not regenerated in this commit: doing so requires network access to fetch git dependencies (e.g. dfinity-lab/build-info) that this sandbox cannot reach. Cargo.lock and the Bazel crate index lockfiles are expected to be regenerated by CI's lockfile-autofix job. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGJa83RwZsAEkJK5YRtef1
…ntime-0.2.3 # Conflicts: # Cargo.Bazel.json.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Nicolas Mattia, Mathias Björkqvist · Slack thread
Summary
Bump the
ic-canister-runtimepin in the rootCargo.tomlfrom0.2.0to0.2.3so thatcanhttp(and anything depending on it) stops pulling inic-cdk 0.19transitively.Before:
ic-canister-runtime = "0.2.0"(resolves to0.2.1inCargo.lock), which depends onic-cdk 0.19.0.canhttp's latest release already moved toic-cdk 0.20+ic-canister-runtime, but becauseic-canister-runtimeitself was pinned to an old version here, that path kept resolving back down toic-cdk 0.19.After:
ic-canister-runtime = "0.2.3"(the latest version on crates.io as of this PR), which depends onic-cdk ^0.20.1. This letscanhttpand its dependents resolve ontoic-cdk 0.20instead of0.19.Related/context:
ic-cdkdependency to0.20.2, but explicitly leaves this transitive path throughic-canister-runtimefor later ("This will be handled separately").ic-cdk::callcall sites to the newCallAPI).ic-canister-runtimepin, so this PR is complementary, not redundant, and can land independently of them.Changes
Cargo.toml:ic-canister-runtime = "0.2.0"→"0.2.3"bazel/rust.MODULE.bazel: matchingcrate.spec(package = "ic-canister-runtime", version = "^0.2.0")→"^0.2.3"Known limitation / what still needs to happen in CI
Cargo.lockand the Bazel crate-index lockfiles (Cargo.Bazel.json.lock/Cargo.Bazel.toml.lock) are not regenerated in this PR. Regenerating them (cargo update,./bin/bazel-pin.sh) requires fetching workspace git dependencies (e.g.dfinity-lab/build-info, used elsewhere in the workspace) that this sandbox environment cannot reach, andbazelitself is not available in the sandbox. I expect CI's lockfile-autofix job to regenerate both lockfiles against thisCargo.toml/MODULE.bazelchange.How Verified
Confirmed on crates.io that
ic-canister-runtime 0.2.3is the latest published version and itsCargo.tomldepends onic-cdk ^0.20.1(not0.19). Could not runcargo check/bazel buildlocally for the reason above — please rely on CI for the actual lockfile regeneration and build/test verification.