feat: prettify bytes ourselves - #11062
Open
nmattia wants to merge 6 commits into
Open
Conversation
This drops the [pretty-bytes](https://crates.io/crates/pretty-bytes) dependency (last update 9 years ago). Instead we now make the bytes pretty ourselves. This cleans up our dependency graph and closes the following (low severity) vulnerability: GHSA-g98v-hv3f-hcfr
nmattia
force-pushed
the
nm-pretty-bytes
branch
from
August 7, 2026 09:47
f5a1036 to
9df4c3a
Compare
nmattia
marked this pull request as ready for review
August 7, 2026 10:46
nmattia
enabled auto-merge
August 7, 2026 10:46
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
✅ No security or compliance issues detected. Reviewed everything up to dd90b34. Security Overview
Detected Code Changes
|
basvandijk
approved these changes
Aug 7, 2026
Resolves merge conflict in Cargo.Bazel.json.lock by taking origin/master's version wholesale (git checkout --theirs); CI's Lock Generate autofix job will regenerate the correct content. No other conflicts. Verified the PR's own changes (removal of pretty-bytes/atty deps, hand-rolled pretty_bytes() in sns_governance_mem_test_canister.rs) survived intact.
# Conflicts: # Cargo.Bazel.json.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops the pretty-bytes dependency (last update 9 years ago). Instead we now make the bytes pretty ourselves.
This cleans up our dependency graph and closes the following (low severity) vulnerability: GHSA-g98v-hv3f-hcfr