fix: resolve gosec G404 and G101 findings - #1143
Draft
skevetter wants to merge 1 commit into
Draft
Conversation
Replace math/rand with crypto/rand in pkg/random and pkg/util (G404). Annotate non-credential constants flagged as hardcoded credentials in pkg/image/auth.go and pkg/config/context.go (G101).
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 3ac782f8-eba2-48a7-b49c-70bd8d3e1476. Replace math/rand with crypto/rand-backed helpers in pkg/random and pkg/util/rand.go (G404 weak randomness); annotate non-credential constants in pkg/image/auth.go (service account token file path) and pkg/config/context.go (context option names) with justified //nolint:gosec for G101. Verification: gosec clean on pkg/random + pkg/util; golangci-lint run on all four touched packages shows no new findings (remaining are pre-existing on untouched lines); scoped go test of touched packages and all consumers passes; full task cli:test fails only in hack/sign_commit and pkg/git, confirmed pre-existing on base branch.