fix: silence gosec G204 on intentional exec calls - #1141
Draft
skevetter wants to merge 1 commit into
Draft
Conversation
Annotate subprocess invocations that are intentionally dynamic with #nosec G204 justifications: su-based command execution, vcluster/vscode CLI wrappers, apk installs, and ssh session shells. Clears all gosec G204 findings.
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task d18ab027-f8da-42f0-bf44-c2b41582dee3. Annotate intentionally dynamic subprocess invocations with
#nosec G204justifications: su-based command execution (pkg/command), vcluster login (pkg/devsyconfig), vscode CLI wrappers and apk install (pkg/ide/vscode), ssh session shell execution (pkg/ssh/server). Clears all gosec G204 findings in those packages; no behavior change. Verification: golangci-lint run on pkg/command, pkg/devsyconfig, pkg/ide/vscode, pkg/ssh/server shows zero G204 (remaining findings pre-existing, out of scope); go test on the four packages passes; task cli:format applied.