fix(lint): audit gosec G703/G704 taint sinks - #1140
Draft
skevetter wants to merge 1 commit into
Draft
Conversation
Annotate five taint-analysis findings where the tainted input is self-owned infrastructure: workspace busy-file paths resolved by the agent, marker files under the fixed ContainerDataDir, GPG socket links derived from $HOME and the current uid, the agent-written image config path, and localhost credential posts on the agent-injected workspace port.
✅ Deploy Preview for devsydev canceled.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 8a5eca13-1398-4a72-af1a-1be681421cf0. Annotate five gosec taint-analysis findings (G703 path traversal, G704 SSRF) where the tainted input is self-owned infrastructure: agent-resolved workspace busy-file paths (pkg/agent/agent.go), agent-written image config path (pkg/agent/dockerless.go), marker files under the fixed ContainerDataDir (pkg/devcontainer/setup/setup.go), GPG socket links derived from $HOME/uid (pkg/gpg/gpg_forwarding.go), and localhost credential posts on the agent-injected workspace port (pkg/dockercredentials/helper.go). Verification: golangci-lint run on all four touched package trees — zero remaining G703/G704 findings, no lll regressions; go test green on pkg/agent/..., pkg/gpg, pkg/devcontainer/setup, pkg/dockercredentials.