fix: suppress gosec G117 on credential marshals - #1139
Draft
skevetter wants to merge 1 commit into
Draft
Conversation
Add #nosec G117 annotations where structs legitimately carry secrets in JSON: docker/git credential tunnel responses, the localhost git credentials request, persisted client config, and test fixture credentials.
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 3de21e14-e6bf-4178-ac2a-f6ad57c53002. Adds
// #nosec G117annotations where JSON marshaling legitimately carries secret fields (G117): docker/git credential tunnel responses in pkg/agent/tunnelserver, the localhost git credentials request in cmd/internal, persisted client config access key in pkg/platform/client, and test fixture credentials in pkg/dockercredentials.Verification: golangci-lint gosec run over all four packages shows 0 remaining G117 findings; scoped
go testfor ./pkg/agent/tunnelserver/... ./pkg/dockercredentials/... ./cmd/internal/... ./pkg/platform/client/... all pass.