fix: add ReadHeaderTimeout to http servers (G112) - #1138
Draft
skevetter wants to merge 1 commit into
Draft
Conversation
Set a 5s ReadHeaderTimeout on the daemon local server and the login callback server to satisfy gosec G112 (slowloris mitigation).
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 8a520d85-d633-4122-8e05-8f6a1311d5b9. Set a 5s ReadHeaderTimeout on the daemon local server (
pkg/daemon/platform/local_server.go) and the login callback server (pkg/platform/client/client.go), resolving gosec G112 (slowloris) findings. Verification:go test ./pkg/daemon/platform/... ./pkg/platform/client/...pass; golangci-lint shows no G112 on touched packages (remaining findings pre-exist on untouched code); fulltask cli:testfailures in pkg/git and hack/sign_commit reproduce on a clean tree without this change.