fix(lint): audit gosec G106/G402 insecure TLS sites - #1137
Draft
skevetter wants to merge 1 commit into
Draft
Conversation
Annotate seven self-owned-infrastructure sites with documented nosec rationale: SSH host key checks target agent-managed servers reachable only through the tailnet/workspace, and InsecureSkipVerify targets reachability probes and login flows against the user's own pro instance which uses a self-signed certificate.
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 8d85d5c3-0803-4be0-ac74-b562eea54c8c. Audit gosec G106/G402 findings in pkg/ts/ssh.go, pkg/ssh/helper.go, pkg/ts/derp.go, cmd/pro/start.go. All seven sites target self-owned infrastructure (agent-managed SSH servers reachable only through the tailnet/workspace; reachability probes and login flows against the user's own pro instance with a self-signed certificate), so real known-hosts/CA verification is not feasible without new infrastructure — each site now carries a documented
#nosecrationale per the task note and the repo's existing convention.Verification:
golangci-lint run ./pkg/ts/... ./pkg/ssh/... ./cmd/pro/...: no G106/G402 findings remain (other pre-existing findings untouched).go test ./pkg/ts/... ./pkg/ssh/... ./cmd/pro/...: pass.task cli:testfailures (e2e, pkg/git clone tests, hack/sign_commit) reproduced on clean tree — pre-existing/environmental.