Bound waiver audit history reads - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
os.ReadFileandjson.Unmarshalwith no size cap, which allowed repository-controlled cache files to cause unbounded memory allocation and CI OOMs.Description
os.ReadFile/json.Unmarshalpath inLoadWaiverAuditHistorywith the sharedcachefile.Loadcall and importinternal/codeguard/cachefileto apply the existing size cap.os.ReadFileand inlinejson.Unmarshalusage frominternal/codeguard/runner/support/waiver_audit_history.go.tests/support/waiver_audit_history_test.gocontainingTestLoadWaiverAuditHistoryRejectsOversizedFilewhich writes a file slightly larger than 32 MiB and asserts the loader treats it as a cache miss.Testing
go test ./tests/supportandgo test ./internal/codeguard/runner/...and all tests passed.TestLoadWaiverAuditHistoryRejectsOversizedFilepassed and verifies oversized waiver-audit history files are rejected.gofmtwas applied to the modified files prior to testing.Codex Task