fix(security): contain slop history writes - #136
Merged
alxxjohn merged 4 commits intoAug 19, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DiffText) flows from persisting state to repository-configured cache locations during transient validation runs.Description
DiffTextby returning early fromrecordSlopHistory; change ininternal/codeguard/checks/quality/quality_ai_history.gotouches the imports and adds theDiffTextguard usingstrings.TrimSpace(env.DiffText).cachefile.DerivedPathand reject configurations that would resolve the derived.slop-historyoutside the config directory, implemented ininternal/codeguard/config/io.goalongside the existing legibility-history check.cachefilehelpers (no change tocachefile.Writebehavior); new path containment check prevents symlink-based escapes.tests/checks/quality_ai_history_test.go) and a containment test that asserts a derivedcache.slop-history.jsonsymlink is rejected (tests/security/config_containment_paths_test.go).Testing
go test ./tests/security ./tests/checksand the suites passed (okreported for both packages).go test ./tests/checks -run TestSlopScoreHistoryDoesNotWriteDuringPatchValidation -count=1which passed.go test ./...to exercise the full test suite in this environment and observed success for the modified packages.Codex Task