Skip to content

#2187: Passing ProcessMode.BACKGROUND_SILENT when running SoapUi - #2194

Open
MariusFreyer wants to merge 6 commits into
devonfw:mainfrom
MariusFreyer:feature/2187-soapui-commandlet-starts-soapui-in-foreground
Open

#2187: Passing ProcessMode.BACKGROUND_SILENT when running SoapUi#2194
MariusFreyer wants to merge 6 commits into
devonfw:mainfrom
MariusFreyer:feature/2187-soapui-commandlet-starts-soapui-in-foreground

Conversation

@MariusFreyer

@MariusFreyer MariusFreyer commented Jul 21, 2026

Copy link
Copy Markdown

This PR fixes #2187

Implemented changes:

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Run "ide soapui". SoapUI should start without logging to the console and blocking it while running.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 21, 2026
@MariusFreyer MariusFreyer self-assigned this Jul 21, 2026
@CLAassistant

CLAassistant commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coveralls

coveralls commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30586993056

Coverage decreased (-0.002%) to 72.619%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 4 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

4 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/soapui/SoapUi.java 3 55.56%
com/devonfw/tools/ide/version/VersionSegment.java 1 91.34%

Coverage Stats

Coverage Status
Relevant Lines: 17284
Covered Lines: 13086
Line Coverage: 75.71%
Relevant Branches: 7653
Covered Branches: 5023
Branch Coverage: 65.63%
Branches in Coverage %: Yes
Coverage Strength: 3.21 hits per line
💛 - Coveralls

@MariusFreyer MariusFreyer moved this from 🆕 New to Team Review in IDEasy board Jul 22, 2026
@MariusFreyer MariusFreyer added enhancement New feature or request ready-to-implement uv fast Python package and project manager labels Jul 22, 2026
@Paras14

Paras14 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Hi @MariusFreyer, thanks for your contribution, two things that stand out:

  1. The entry in Changelog is in the wrong release section, since the ticket opened the main has moved forward. Once you do a git pull/fetch, you'll find a new 2026.08.001 section, you must put your entry under that.

  2. Please make sure to put a blank line after the opening brace, for any function or class. You can find more details regarding this in the coding-conventions.adoc

@Paras14 Paras14 moved this from Team Review to 👀 In review in IDEasy board Jul 28, 2026
@MariusFreyer

MariusFreyer commented Jul 28, 2026

Copy link
Copy Markdown
Author

@Paras14 Thanks for your remarks. I fixed both of them.

hohwille
hohwille approved these changes Jul 30, 2026
View reviewed changes

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MariusFreyer thanks for your PR. Fix works correct. 👍
I left some small review comments for improvement.
Please resolve so we can merge.

Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/soapui/SoapUi.java
Comment on lines +15 to +19
private static final String SOAPUI = "soapui";

private static final String SOAPUI_BAT = SOAPUI + ".bat";

private static final String SOAPUI_BAT = SOAPUI + ".bat";
private static final String SOAPUI_BASH_SCRIPT = SOAPUI + ".sh";

@hohwille hohwille Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your indentation is broken (we have a common coding style for IDEasy configured via .editorconfig that specifies indentation as 2 spaces not 4).
Please check your IDE. Aren't you using IDEasy together with IntelliJ for development?

Comment thread cli/src/main/java/com/devonfw/tools/ide/tool/soapui/SoapUi.java
super(ideContext, SOAPUI, Set.of(Tag.TEST, Tag.REST));
}
@Override
protected void doRun() {

@hohwille hohwille Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we override runTool(List<String> args) instead?
If that method would be called, process would still run in DEFAULT mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@MariusFreyer MariusFreyer

@Paras14 Paras14

Labels

enhancement New feature or request ready-to-implement uv fast Python package and project manager

Projects

IDEasy board
Status: 👀 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SoapUI commandlet starts soapui in foreground

5 participants

@MariusFreyer @CLAassistant @coveralls @Paras14 @hohwille