Fix Wayland overlay flicker by honoring SHM buffer lifetimes - #334
Merged
Conversation
Keep the configured swapchain slots alive and defer renders while all buffers remain compositor-owned. Track those deferrals separately, scope inline hover damage, and preserve dialog entry/restoration semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #318
Buffer::attach_to()so SHM slots remain active untilwl_buffer.release.restoration accepts a deferred repaint so a selected file is never discarded.
Root cause
The main overlay attached the raw
wl_bufferdirectly to the Wayland surface. This bypassed SCTK’s slot activation.When the inactive
Bufferwas dropped, its SHM memory returned to the pool’s free list before the compositor sentwl_buffer.release. With vsync disabled, the next frame could immediately repaint the same memory while the compositor was still presenting it, producing toolbar and annotation flicker.This also meant the configured buffer count was ineffective and prevented the existing per-slot damage tracking from operating over a real swapchain.