fix: ignore unknown fields on nested response models - #69
Merged
Conversation
*Dto already used extra='ignore'; nested shapes like StatusPageBranding and check-detail variants still forbade extras, so the next additive API field would crash get/list the same way openIncident broke MCP 1.4.0. Request/Params stay extra='forbid'. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_response_shapeso every generated model that is not*Request/*Paramsusesextra='ignore'(Postel's Law).*Dtoalready did this; nested shapes likeStatusPageBrandingand check-detail variants (Http,Dns,Tcp) still forbade extras.openIncident/ component override fields — the next additive API field on branding would crashget/listagain.extra='forbid'. Tests cover branding, component null extras,openIncident: null, and the classifier.Linear: https://linear.app/devhelm/issue/END-489664
Test plan
uv run pytest tests/(802 passed)StatusPageBranding.model_validate({fontFamily: ...})succeedsCreateStatusPageRequeststill rejects unknown top-level keys./scripts/release.sh 1.6.0on main) so MCP can pick up the nested-shape fix on the next lock refreshMade with Cursor