feat: implement ability to select extra columns for tooltips - #149
Merged
Conversation
timothygachengo
requested review from
ralvarez-dg
and
a lite review from Copilot
August 26, 2026 09:46
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the Map block editor for selecting additional dataset fields that should be available as tooltip template variables (without making them full dimensions), and persists that selection into the block’s saved markup.
Changes:
- Introduces a new
extraTooltipColumnsblock attribute for the map block. - Adds an “Extra Tooltip Columns” inspector panel (non-CSV mode) with checkboxes for available dimensions.
- Persists
extraTooltipColumnsto the frontend via a newdata-extra-tooltip-columnsattribute and surfaces them in the tooltip variable guide.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/wp-react-blocks-plugin/blocks/map/Tooltips.js | Adds UI to select extra tooltip columns and displays them as available tooltip variables. |
| plugins/wp-react-blocks-plugin/blocks/map/index.js | Defines the new extraTooltipColumns block attribute with a default empty array. |
| plugins/wp-react-blocks-plugin/blocks/map/BlockSave.js | Serializes extraTooltipColumns into the saved block markup as a data attribute. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <Text size="xSmall" style={{ fontSize: '12px', marginTop: '4px'}}>MEASURES</Text> | ||
| {allMeasures && | ||
| allMeasures.map((m) => ( | ||
| <PanelRow key={m}> |
ralvarez-dg
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-wp-commons@devgateway/create-wp-customizer@devgateway/upgrade-wp-customizerplugins/wp-react-blocks-pluginplugins/wp-react-custom-apiplugins/wp-react-custom-rest-menuChecklist
pnpm buildpasses locally