chore: fix tabbed posts - #289
Merged
Merged
Conversation
timothygachengo
requested review from
ralvarez-dg
and
a lite review from Copilot
August 27, 2026 12:25
commit: |
ralvarez-dg
approved these changes
Aug 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a WordPress “tabbed posts” embeddable edge case during editor rendering by short-circuiting rendering when required configuration (data-type) is missing.
Changes:
- Add an early return in the TabbedPosts
Wrapperto avoid rendering the main content tree in editing mode whentypeis not available. - Add a changeset for
@devgateway/dvz-ui-reactdescribing the bug fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/dvz-ui/src/embeddable/tabbedposts/index.jsx | Adds an editing-mode guard when data-type isn’t loaded. |
| .changeset/bumpy-dingos-spend.md | Publishes the patch changeset note for the fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses