feat: implement ability to select extra columns for tooltips - #285
Merged
Conversation
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for selecting additional dataset columns to be returned by the API and exposed as variables for map tooltip templating (without adding them to the query breakdown), improving tooltip customization for embeddable maps.
Changes:
- Adds
data-extra-tooltip-columnshandling and maps it to anincludeColumnsquery param. - Improves “dimension3/extra dimension” filter lookup by supporting normalized-key matching.
- Extends per-row variable extraction to include stable aliases (
dimension3,additionalDimension) for tooltip templates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/dvz-ui/src/embeddable/map/MapDataFrame.jsx | Adds per-row extra dimension resolution and tooltip variable aliases. |
| packages/dvz-ui/src/embeddable/map/index.jsx | Adds extra tooltip columns param parsing and normalized filter-key lookup for extra dimension. |
| .changeset/common-states-shake.md | Publishes the feature as a patch changeset for @devgateway/dvz-ui-react. |
Suppressed comments (1)
packages/dvz-ui/src/embeddable/map/index.jsx:304
- This block can add
params[extraDimension]while leaving the original (normalized-match) key in place, causing duplicate filter params to be sent. IfgetParamValueByKeyfound a different key, delete it after copying.
const dimension3Value = getParamValueByKey(params, extraDimension);
if (dimension3Value !== undefined && dimension3Value !== null && dimension3Value !== '') {
params[extraDimension] = dimension3Value;
}
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ralvarez-dg
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses