Skip to content

feat: implement ability to select extra columns for tooltips - #285

Merged
ralvarez-dg merged 2 commits into
mainfrom
task/fix-map-variables-to-show
Aug 26, 2026
Merged

feat: implement ability to select extra columns for tooltips#285
ralvarez-dg merged 2 commits into
mainfrom
task/fix-map-variables-to-show

Conversation

@timothygachengo

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Breaking change (BREAKING CHANGE:)
  • Refactor / chore (refactor: / chore:)
  • Documentation update (docs:)

Affected package(s)

  • @devgateway/dvz-ui-react
  • @devgateway/wp-react-lib
  • example only (no changeset needed)

Checklist

  • PR title follows Conventional Commits format
  • A changeset has been added (pnpm changeset) for any change to a published package
  • pnpm build passes locally
  • pnpm --filter @devgateway/* typecheck passes
  • No hardcoded credentials, internal URLs, client names, or PII introduced
  • Any new dependency has an Apache-2.0-compatible license

Copilot AI lite review requested due to automatic review settings August 26, 2026 09:44
@pkg-pr-new

pkg-pr-new Bot commented Aug 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@devgateway/dvz-ui-react@a900199
pnpm add https://pkg.pr.new/@devgateway/wp-react-lib@a900199

commit: a900199

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for selecting additional dataset columns to be returned by the API and exposed as variables for map tooltip templating (without adding them to the query breakdown), improving tooltip customization for embeddable maps.

Changes:

  • Adds data-extra-tooltip-columns handling and maps it to an includeColumns query param.
  • Improves “dimension3/extra dimension” filter lookup by supporting normalized-key matching.
  • Extends per-row variable extraction to include stable aliases (dimension3, additionalDimension) for tooltip templates.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/dvz-ui/src/embeddable/map/MapDataFrame.jsx Adds per-row extra dimension resolution and tooltip variable aliases.
packages/dvz-ui/src/embeddable/map/index.jsx Adds extra tooltip columns param parsing and normalized filter-key lookup for extra dimension.
.changeset/common-states-shake.md Publishes the feature as a patch changeset for @devgateway/dvz-ui-react.
Suppressed comments (1)

packages/dvz-ui/src/embeddable/map/index.jsx:304

  • This block can add params[extraDimension] while leaving the original (normalized-match) key in place, causing duplicate filter params to be sent. If getParamValueByKey found a different key, delete it after copying.
        const dimension3Value = getParamValueByKey(params, extraDimension);
        if (dimension3Value !== undefined && dimension3Value !== null && dimension3Value !== '') {
            params[extraDimension] = dimension3Value;
        }
    }

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/dvz-ui/src/embeddable/map/index.jsx
Comment thread packages/dvz-ui/src/embeddable/map/MapDataFrame.jsx
@ralvarez-dg
ralvarez-dg merged commit e3b4b3f into main Aug 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants