-
Notifications
You must be signed in to change notification settings - Fork 1
fix(tui): render terminal assistant messages #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dennisonbertram
merged 3 commits into
main
from
codex/issue-1056-terminal-assistant-message
Aug 1, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an earlier tool-calling step emitted text deltas,
responseStartedremains true afterhandleToolStartappends the tool card. If the later terminal step is non-streaming, this call reachesrenderActiveAssistantBubble, which usesReplaceTailLines(activeAssistantLineCount, ...)even though the viewport tail is now the tool card; it therefore removes part or all of that card and leaves its recorded line offsets stale. This can occur with the supported per-turn mix of deltas/tool calls followed by a final-only response, so the terminal reconciliation must append or replace the tracked assistant bubble without treating unrelated tail content as that bubble.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed at exact head
ebe2d9a85954cea45e0763cabec57ebba747e08c.The regression now drives the realistic sequence
assistant.message.delta -> tool.call.started -> tool.output.delta -> tool.call.completed -> assistant.message, replays the tool completion and terminal event, then replays terminal completion and starts a later run. It asserts the early assistant bubble, tool card, and final-only assistant bubble remain ordered and appear exactly once, the transcript finalizes once, and the later run records normally.The minimal ownership fix closes the preceding assistant bubble when
handleToolStartappends the tool card; the next provider step starts a fresh accumulator. Terminal replay is also ignored once that run's response is finalized.Verification: focused normal/race, complete TUI normal/race, all
cmd/harnesscli/..., and foreground non-TTY./scripts/test-regression.shall pass; coverage is 85.6% with zero uncovered functions. The unrelated hosted fixture race remains #1044 / PR #1045 and was not folded into this PR.