refactor: Toolset refactoring - pt. 1 - #12298
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
topic:tests
type:documentation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
anakin87
changed the title
anakin87
changed the title
anakin87
marked this pull request as ready for review
August 11, 2026 09:32
sjrl
reviewed
Aug 11, 2026
Comment on lines
570
to
574
| def _warm_up_hooks(self) -> None: | ||
| """Warm up the configured hooks once.""" | ||
| if not self._hooks_warmed_up: | ||
| warm_up_hooks(self.hooks) | ||
| self._hooks_warmed_up = True |
Contributor
There was a problem hiding this comment.
Should we open a follow up issue to similarly remove this guard for Hooks?
Member
Author
There was a problem hiding this comment.
I think I'll handle this in the Agent mutation work but yes, it's something to take into consideration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
First part of the refactoring proposed in the PR above:
spawn()andget_selectable_tools()implementations in the base class, but move specific behaviors toSearchableToolsetwarm_up: remove_is_warmed_upflag; makeAgent.warm_up()callwarm_up_toolson every call. This is more aligned with otherwarm_upmethods in Haystack, but now a specific implementation must know how to avoid doing expensive work multiple times.+support; deprecateaddsupport forToolset. Users can still passtools=[my_toolset, another_toolset]How did you test it?
CI, new tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.