Skip to content

test: enable mypy typing checks for test/components/writers/ - #12272

Merged
davidsbatista merged 2 commits into
deepset-ai:mainfrom
Aryan-Pardeshi:fix/typing-test-components-writers
Aug 10, 2026
Merged

test: enable mypy typing checks for test/components/writers/#12272
davidsbatista merged 2 commits into
deepset-ai:mainfrom
Aryan-Pardeshi:fix/typing-test-components-writers

Conversation

@Aryan-Pardeshi

Copy link
Copy Markdown
Contributor

Fixes #10396

Context

Part of the ongoing effort (#10396) to incrementally enable mypy typing checks across test directories.

Changes

  • Added \ est/components/writers/\ to the \ ypes\ script target list in \pyproject.toml.
  • Fixed a type error in \ est/components/writers/test_document_writer.py\ (\ est_run_async_invalid_docstore) where \DocumentWriter\ was passed the \mocked_docstore_class\ reference rather than an instance \mocked_docstore_class().
  • All 13 tests in \ est/components/writers/\ pass and mypy reports 0 errors.

@Aryan-Pardeshi
Aryan-Pardeshi requested a review from a team as a code owner August 7, 2026 21:22
@Aryan-Pardeshi
Aryan-Pardeshi requested review from davidsbatista and removed request for a team August 7, 2026 21:22
@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

@Aryan-Pardeshi is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Aug 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @Aryan-Pardeshi, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from davidsbatista August 7, 2026 22:29
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Aug 7, 2026
@HaystackBot
HaystackBot marked this pull request as draft August 7, 2026 22:29
@HaystackBot
HaystackBot marked this pull request as ready for review August 8, 2026 05:08
@HaystackBot HaystackBot removed the cla-pending PR is in draft until the contributor signs the CLA label Aug 8, 2026
@HaystackBot

Copy link
Copy Markdown
Contributor

Thanks for signing the CLA, @Aryan-Pardeshi! 🎉 This PR is now ready for review again and the reviewer has been re-assigned.

@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview Aug 10, 2026 1:53pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/core/pipeline
  pipeline.py
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista
davidsbatista merged commit 842519e into deepset-ai:main Aug 10, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run typing checks on our test files

4 participants