fix: Fix sliding window compactor to also retain historical user-assistant turns if the budget allows - #12270
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sjrl
commented
Aug 7, 2026
anakin87
reviewed
Aug 10, 2026
sjrl
marked this pull request as ready for review
August 10, 2026 10:59
sjrl
requested review from
anakin87 and
davidsbatista
and removed request for
a team and
davidsbatista
August 10, 2026 10:59
anakin87
approved these changes
Aug 10, 2026
anakin87
left a comment
anakin87
left a comment
Member
There was a problem hiding this comment.
Just one little comment left
sjrl
force-pushed
the
fix-sliding-window
branch
from
August 11, 2026 07:29
85bd98e to
1a971d5
Compare
…nto fix-sliding-window
Contributor
Author
|
@anakin87 sorry for the messed up history, I was trying out the new github stacked PR feature and in the end it wasn't quite working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
The first built-in strategy,
SlidingWindowCompactor, preserves leading system messages, the latest user task, and as much complete recent conversation as the target allows. NEW: It removes earlier user/assistant turns as whole units first. Only when removing all earlier turns is insufficient does it remove individual Agent steps from the current task. It replaces removed history with a short omission note.How did you test it?
New tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.